Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:128198
Precedence: bulk
MIME-Version: 1.0
References: <CAEKnhAF3KOGcWZ6CYxpWkpZbNOGo79DD7p=WsAoJvqdJ5xG_Uw@mail.gmail.com>
 <CAMU7ir+672N6wJUs3-MoyF-EEpqmmyGh19SA7qZEuGCmv56fCQ@mail.gmail.com>
In-Reply-To: <CAMU7ir+672N6wJUs3-MoyF-EEpqmmyGh19SA7qZEuGCmv56fCQ@mail.gmail.com>
Date: Wed, 23 Jul 2025 17:41:47 +0200
Message-ID: <CAEKnhAH=pRZTd+wOacdfpTKo+TjJxXBFq34SBp=G56NYSiYK5Q@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] JSON Schema validation support
To: Alexandre Daubois <alex.daubois+php@gmail.com>
Cc: PHP internals list <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000009f2cfa063a9a8c3f"
From: bukka@php.net (Jakub Zelenka)

--0000000000009f2cfa063a9a8c3f
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Alex,

On Wed, Jul 23, 2025 at 3:57=E2=80=AFPM Alexandre Daubois <
alex.daubois+php@gmail.com> wrote:

> Thank you for proposing such a feature! I personally really like it
> and would be glad to see this land into PHP.
> I think it would be even more useful if JsonSchema offers more ways to
> load a schema. Schemas are often either remotely stored or stored in a
> file.
>

 Yes, this is exactly the reason why it's using a static method and not a
constructor

It would be great to add two new factory methods:
> JsonSchema::fromUri() and JsonSchema::fromFile().


Yeah something like this is planned in the next stage. In addition it could
be useful to create it from array or from class (sort of auto generate
schema) as well but that's all feature scope.


> Maybe
> JsonSchema::createFromString() should also be renamed to fromString()
> to be consistent with the recent additions to XMLReader.
>

 I actually took that name from recently
introduced HTMLDocument::createFromString and XMLDocument::createFromString
. So not sure what is more consistent. Personally I don't really mind.

Kind regards

Jakub

--0000000000009f2cfa063a9a8c3f
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi Alex,</div><div><br></div><div dir=3D"ltr">On Wed,=
 Jul 23, 2025 at 3:57=E2=80=AFPM Alexandre Daubois &lt;<a href=3D"mailto:al=
ex.daubois%2Bphp@gmail.com">alex.daubois+php@gmail.com</a>&gt; wrote:</div>=
<div class=3D"gmail_quote gmail_quote_container"><blockquote class=3D"gmail=
_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204=
,204);padding-left:1ex">
Thank you for proposing such a feature! I personally really like it<br>
and would be glad to see this land into PHP.<br>
I think it would be even more useful if JsonSchema offers more ways to<br>
load a schema. Schemas are often either remotely stored or stored in a<br>
file.<br></blockquote><div><br></div><div>=C2=A0Yes, this is exactly the re=
ason why it&#39;s using a static method and not a constructor</div><div><br=
></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;=
border-left:1px solid rgb(204,204,204);padding-left:1ex">
It would be great to add two new factory methods:<br>
JsonSchema::fromUri() and JsonSchema::fromFile(). </blockquote><div><br></d=
iv><div>Yeah something like this is planned in the next stage. In addition =
it could be useful to create it from array or from class (sort of auto gene=
rate schema) as well but that&#39;s all feature scope.</div><div>=C2=A0</di=
v><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;borde=
r-left:1px solid rgb(204,204,204);padding-left:1ex">Maybe<br>
JsonSchema::createFromString() should also be renamed to fromString()<br>
to be consistent with the recent additions to XMLReader.<br></blockquote><d=
iv><br></div><div>=C2=A0I actually took that name from recently introduced=
=C2=A0HTMLDocument::createFromString and XMLDocument::createFromString . So=
 not sure what is more consistent. Personally I don&#39;t really mind.</div=
><div><br></div><div>Kind regards</div><div><br></div><div>Jakub</div></div=
></div>

--0000000000009f2cfa063a9a8c3f--