Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:128167
Precedence: bulk
MIME-Version: 1.0
References: <CALaXqqRu0DBHpTNavte9FcaXQDf8PZ8W=4QR=dhDGajQ5devaA@mail.gmail.com>
 <CALaXqqT67YmMuUDp-83ZSYk+x8hhjhw=ZT=a8qC=qdFO7UuOTg@mail.gmail.com>
In-Reply-To: <CALaXqqT67YmMuUDp-83ZSYk+x8hhjhw=ZT=a8qC=qdFO7UuOTg@mail.gmail.com>
Date: Mon, 21 Jul 2025 20:31:47 +0200
Message-ID: <CAOWwgp=pgUY_iaZ_YnHMvzVbRL9AyQAp058QAf_0kQPb+LnruQ@mail.gmail.com>
Subject: Re: [PHP-DEV] Re: [VOTE] RFC: #[\DelayedTargetValidation] attribute
To: Daniel Scherzer <daniel.e.scherzer@gmail.com>
Cc: php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000ee8bb3063a74b03c"
From: nicolas.grekas+php@gmail.com (Nicolas Grekas)

--000000000000ee8bb3063a74b03c
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Le lun. 21 juil. 2025 =C3=A0 20:23, Daniel Scherzer <daniel.e.scherzer@gmai=
l.com>
a =C3=A9crit :

> On Thu, Jul 17, 2025 at 9:21=E2=80=AFAM Daniel Scherzer <
> daniel.e.scherzer@gmail.com> wrote:
>
>> Hi internals,
>>
>> Voting is now open for this RFC.
>>
>> * RFC: https://wiki.php.net/rfc/delayedtargetvalidation_attribute
>> * Discussion thread: https://externals.io/message/127702
>>
>> Voting will end 2025-07-31 at end-of-day UTC.
>>
>> -Daniel
>>
>
> For those who are still debating how to vote, or who voted no, I want to
> highlight the "Extend #[\Override] to target properties" RFC currently in
> voting as an example of a use case. See
> https://wiki.php.net/rfc/override_properties.
>
> Specifically, if we had already added #[\DelayedTargetValidation] as part
> of 8.4, and that other RFC passes, there would have been a place to use i=
t
> - on class properties in code that supports 8.4 and 8.5 but wants to
> indicate that the property overrides a parent property. Fundamentally,
> #[\DelayedTargetValidation] needs to be introduced *before* it is useful,
> because it is designed for supporting attributes that change in future
> versions of PHP. Introducing it in 8.5 might not help for #[\Override] on
> property, but it would help for any attribute changes in 8.6+, e.g. if
> #[\Override] starts to support class constants.
>

I voted in favor of the RFC precisely because of this capability, which is
very much needed in code bases I deal with. Not having this will force us,
authors, to create workarounds based on eg @annotations. Worst is that
these workarounds will have to remain for a never ending amount of time as
new attributes are introduced to the engine.

Nicolas

>

--000000000000ee8bb3063a74b03c
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><br><br><br><div class=3D"gmail_quote gmail_quote_contain=
er" dir=3D"auto"><div dir=3D"ltr" class=3D"gmail_attr">Le lun. 21 juil. 202=
5 =C3=A0 20:23, Daniel Scherzer &lt;<a href=3D"mailto:daniel.e.scherzer@gma=
il.com">daniel.e.scherzer@gmail.com</a>&gt; a =C3=A9crit=C2=A0:<br></div><b=
lockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px =
#ccc solid;padding-left:1ex"><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"=
ltr">On Thu, Jul 17, 2025 at 9:21=E2=80=AFAM Daniel Scherzer &lt;<a href=3D=
"mailto:daniel.e.scherzer@gmail.com" target=3D"_blank" rel=3D"noreferrer">d=
aniel.e.scherzer@gmail.com</a>&gt; wrote:</div><div class=3D"gmail_quote"><=
blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l=
eft:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">Hi intern=
als,<br><br>Voting is now open for this RFC.<br><br>* RFC:=C2=A0<a href=3D"=
https://wiki.php.net/rfc/delayedtargetvalidation_attribute" target=3D"_blan=
k" rel=3D"noreferrer">https://wiki.php.net/rfc/delayedtargetvalidation_attr=
ibute</a><br>* Discussion thread:=C2=A0<a href=3D"https://externals.io/mess=
age/127702" target=3D"_blank" rel=3D"noreferrer">https://externals.io/messa=
ge/127702</a><div><br>Voting will end 2025-07-31 at end-of-day UTC.</div><d=
iv><br></div><div>-Daniel</div></div></blockquote><div><br></div>For those =
who are still debating how to vote, or who voted no, I want to highlight th=
e &quot;Extend #[\Override] to target properties&quot; RFC currently in vot=
ing as an example of a use case. See=C2=A0<a href=3D"https://wiki.php.net/r=
fc/override_properties" target=3D"_blank" rel=3D"noreferrer">https://wiki.p=
hp.net/rfc/override_properties</a>.</div><div class=3D"gmail_quote"><br>Spe=
cifically, if we had already added #[\DelayedTargetValidation] as part of 8=
.4, and that other RFC passes, there would have been a place to use it - on=
 class properties in code that supports 8.4 and 8.5 but wants to indicate t=
hat the property overrides a parent property. Fundamentally, #[\DelayedTarg=
etValidation] needs to be introduced *before* it is useful, because it is d=
esigned for supporting attributes that change in future versions of PHP. In=
troducing it in 8.5 might not help for #[\Override] on property, but it wou=
ld help for any attribute changes in 8.6+, e.g. if #[\Override] starts to s=
upport class constants.</div></div></div></blockquote></div><div dir=3D"aut=
o"><br></div><div dir=3D"auto">I voted in favor of the RFC precisely becaus=
e of this capability, which is very much needed in code bases I deal with. =
Not having this will force us, authors, to create workarounds based on eg @=
annotations. Worst is that these workarounds will have to remain for a neve=
r ending amount of time as new attributes are introduced to the engine.</di=
v><div dir=3D"auto"><br></div><div dir=3D"auto">Nicolas=C2=A0</div><div cla=
ss=3D"gmail_quote gmail_quote_container" dir=3D"auto"><blockquote class=3D"=
gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-=
left:1ex"><div dir=3D"ltr">
</div>
</blockquote></div></div>

--000000000000ee8bb3063a74b03c--