Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:128083
Message-ID: <c0cb169e-2388-4b81-b3b6-add815d5a2cf@gmail.com>
Date: Wed, 16 Jul 2025 15:40:34 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] [DISCUSSION] bcmath: adding bcgetopts() and bcsetopts()
 to get or set bcmath options
To: Ayesh Karunaratne <ayesh@php.watch>
Cc: internals@lists.php.net
References: <cf2f88d2-5584-4726-80b7-b9136d31e043@gmail.com>
 <CANLbj-oomrK0ghYrfYf2g3UUgKKRwQ65Q8d1TY2Avy3qr86-cQ@mail.gmail.com>
Content-Language: en-US
In-Reply-To: <CANLbj-oomrK0ghYrfYf2g3UUgKKRwQ65Q8d1TY2Avy3qr86-cQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
From: quakemmo@gmail.com (Quake MMO)


On 7/16/25 13:56, Ayesh Karunaratne wrote:
>> Would adding a bcgetopts(): int and a bcsetopts(int $opts): void calls
>> be useful?
>>
>> At this time there's no way to influence bcmath's behavior other than
>> bcscale().
>>
> How about adding these as methods/properties to the `BcMath\Number` class?
>
> `BcMath\Number` does not use the `bcmath.scale` INI directive, and in
> my opinion, it is the correct way to do it. Everything that affects
> the operations are just there in the code, and there is no hidden
> global state.


That would also totally work. Anything that would allow sanitizing the 
string directly in the extension as opposed to doing it in PHP would be 
a great progress.

I would vouch for the sanitization switch to be a global state setting 
such as the bcscale, as opposed to (only) be a callable method/function. 
This way, we would avoid an extra call from PHP for sanitization.