Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:128058
Precedence: bulk
MIME-Version: 1.0
References: <hzKdzBWWITU1ePjv3qcyK-OzroFAkWst9MQBw2zvKSA8pk1iqruLZZWTTh9gYDo2QX8EY_PiirVYDuwne2Upr3GlqZk570wtLOF49aaP-HQ=@gpb.moe>
 <CAEKnhAGNx_tfhXvsCk9x_XokR82ohAvj12JCri=pDAuWhxkKrg@mail.gmail.com>
In-Reply-To: <CAEKnhAGNx_tfhXvsCk9x_XokR82ohAvj12JCri=pDAuWhxkKrg@mail.gmail.com>
Date: Tue, 15 Jul 2025 19:45:17 +0200
Message-ID: <CAOWwgpnyGw6Z0xPRzz8=p32zUWkFMQDTwUomHjL3n--sUz+gLw@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] Deprecations for PHP 8.5
To: Jakub Zelenka <bukka@php.net>
Cc: "Gina P. Banyard" <internals@gpb.moe>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000009f31800639fb57b2"
From: nicolas.grekas+php@gmail.com (Nicolas Grekas)

--0000000000009f31800639fb57b2
Content-Type: text/plain; charset="UTF-8"

>
> > Deprecate the __sleep() and __wakeup() magic methods
>
> I'm not sure about this one. I don't think it's worth it. It's just an
> unnecessary BC break IMHO. I would also consider more ext/standard thing
> rather than language.
>

I agree with Jakub here, __sleep and __wakeup are just fine. Yes,
__serialize/__unserialize are better, but breaking (or even planning to
break) existing apps doesn't look worth the change.



> > Deprecate the $http_response_header predefined variable
>
> I think it's too early for this. I would prefer to not deprecate it at
> this time because alternative is available only from 8.4...
>

I agree also here: having the alternative available in 8.4 is too soon,
especially since the new function cannot be polyfilled.

No strong feelings about the other proposals, I'll read other's comments in
the thread before voting.

Nicolas

--0000000000009f31800639fb57b2
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_quote"><blockquote cl=
ass=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid=
 rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div class=3D"gmail_qu=
ote"><div>&gt;=C2=A0Deprecate the __sleep() and __wakeup() magic methods</d=
iv><div><br></div><div>I&#39;m not sure about this one. I don&#39;t think i=
t&#39;s worth it. It&#39;s just an unnecessary BC break IMHO. I would also =
consider more ext/standard thing rather than language.=C2=A0</div></div></d=
iv></blockquote><div><br></div><div><div>I agree with Jakub here, __sleep a=
nd __wakeup are just fine. Yes,=20
__serialize/__unserialize are better, but breaking=C2=A0(or even planning t=
o break)
 existing=C2=A0apps doesn&#39;t look worth the change.</div><div><br></div>=
=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0=
.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"l=
tr"><div class=3D"gmail_quote"><div>&gt; Deprecate the $http_response_heade=
r predefined variable</div><div><br></div><div>I think it&#39;s too early f=
or this. I would prefer to not deprecate it at this time because alternativ=
e is available only from 8.4...</div></div></div></blockquote><div><br></di=
v><div>I agree also here: having the alternative available in 8.4 is too so=
on, especially since the new function=C2=A0cannot be polyfilled.</div><div>=
=C2=A0</div><div>No strong feelings about the other proposals, I&#39;ll rea=
d other&#39;s comments in the thread before voting.</div><div><br></div><di=
v>Nicolas</div></div></div>
</div>

--0000000000009f31800639fb57b2--