Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:12801 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 86757 invoked by uid 1010); 14 Sep 2004 16:21:02 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 86733 invoked from network); 14 Sep 2004 16:21:01 -0000 Received: from unknown (HELO jdi.jdimedia.nl) (212.204.192.51) by pb1.pair.com with SMTP; 14 Sep 2004 16:21:01 -0000 Received: from localhost (localhost [127.0.0.1]) by jdi.jdimedia.nl (8.12.11/8.12.11) with ESMTP id i8EGL1gh013931 for ; Tue, 14 Sep 2004 18:21:01 +0200 Received: from localhost (localhost [127.0.0.1]) by jdi.jdimedia.nl (8.12.11/8.12.11) with ESMTP id i8EGKx2f013925; Tue, 14 Sep 2004 18:20:59 +0200 Date: Tue, 14 Sep 2004 18:20:59 +0200 (CEST) X-X-Sender: derick@localhost To: Steph cc: internals In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by amavisd-new at jdimedia.nl Subject: Re: [PHP-DEV] [PATCH] round 3 From: derick@php.net (Derick Rethans) On Tue, 14 Sep 2004, Steph wrote: > Moved #if a few paces to the left on Wez's advice. Fussy old compilers ;) > > Still does the same job (fixes win32 build and all builds where there is no > strcoll), only this time without breaking otherwise happy builds. It's still wrong. The only change needed is the #define HAVE_STRCOLL in zend_config.w32.h Derick -- Derick Rethans http://derickrethans.nl | http://ez.no | http://xdebug.org