Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:128002
Message-ID: <9D5043B2-1589-4FD5-B289-6E98FB1177BE@nicksdot.dev>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_1FB10913-D5B5-462D-9516-ABACE5A87EF6"
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\))
Subject: Re: [PHP-DEV] [RFC] Readonly property hooks
Date: Fri, 11 Jul 2025 11:30:43 +0700
In-Reply-To: <1e8634d7-ac1a-4025-b4e2-1948aabf5251@app.fastmail.com>
Cc: php internals <internals@lists.php.net>
To: Larry Garfield <larry@garfieldtech.com>
References: <1e8634d7-ac1a-4025-b4e2-1948aabf5251@app.fastmail.com>
From: php@nicksdot.dev (Nick)


--Apple-Mail=_1FB10913-D5B5-462D-9516-ABACE5A87EF6
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

Hey all,

> On 8. Jun 2025, at 11:16, Larry Garfield <larry@garfieldtech.com> =
wrote:
>=20
> As Nick has graciously provided an implementation, we would like to =
open discussion on this very small RFC to allow `readonly` on backed =
properties even if they have a hook defined.
>=20
> https://wiki.php.net/rfc/readonly_hooks
>=20
> --=20
>  Larry Garfield
>  larry@garfieldtech.com

To not get this buried in individual answers to others:

I came up with two alternative implementations which cache the computed =
`get` hook value.
One leverages separate cache properties, the other writes directly to =
the backing store.

Links to the alternative branches can be found in the description of the =
original PR.
https://github.com/php/php-src/pull/18757

I believe that these are fair solutions to address the concerns that =
came up in the discussion, and I hope people will agree.

Cheers,
Nick=

--Apple-Mail=_1FB10913-D5B5-462D-9516-ABACE5A87EF6
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html;
	charset=us-ascii

<html><head><meta http-equiv=3D"content-type" content=3D"text/html; =
charset=3Dus-ascii"></head><body style=3D"overflow-wrap: break-word; =
-webkit-nbsp-mode: space; line-break: after-white-space;">Hey all,<br =
id=3D"lineBreakAtBeginningOfMessage"><div><br><blockquote =
type=3D"cite"><div>On 8. Jun 2025, at 11:16, Larry Garfield =
&lt;larry@garfieldtech.com&gt; wrote:</div><br =
class=3D"Apple-interchange-newline"><div><div>As Nick has graciously =
provided an implementation, we would like to open discussion on this =
very small RFC to allow `readonly` on backed properties even if they =
have a hook =
defined.<br><br>https://wiki.php.net/rfc/readonly_hooks<br><br>-- <br> =
&nbsp;Larry Garfield<br> =
&nbsp;larry@garfieldtech.com<br></div></div></blockquote></div><br><div>To=
 not get this buried in individual answers to =
others:</div><div><br></div><div>I came up with two alternative =
implementations which cache the computed `get` hook value.</div><div>One =
leverages separate cache properties, the other writes directly to the =
backing store.</div><div><br></div><div>Links to the alternative =
branches can be found in the description of the original =
PR.</div><div>https://github.com/php/php-src/pull/18757</div><div><br></di=
v><div>I believe that these are fair solutions to address the concerns =
that came up in the discussion, and I hope people will =
agree.</div><div><br></div><div><b>Cheers,</b></div><div>Nick</div></body>=
</html>=

--Apple-Mail=_1FB10913-D5B5-462D-9516-ABACE5A87EF6--