Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127937
Date: Mon, 07 Jul 2025 15:51:10 +0000
To: erictnorris@gmail.com
Cc: Bob Weinand <bobwei9@hotmail.com>, Niels Dossche <dossche.niels@gmail.com>, internals@lists.php.net
Subject: Re: [PHP-DEV] [RFC] Deprecations for PHP 8.5
Message-ID: <tcasRNkvtM6QDRu8NrvHxzWDoaj-61bJ2Q8D1b-9dIJO8ryykpjeiIgTnd5lLiOJJfVTfimUqwhcI0wazxxojwUNhVsUb9jAGHOVe1q-heg=@gpb.moe>
In-Reply-To: <CA+NMNO0wC4iLTtED9y6jWL2XkSrTH8aZ5Kd9f7arT_XA3+Lktw@mail.gmail.com>
References: <hzKdzBWWITU1ePjv3qcyK-OzroFAkWst9MQBw2zvKSA8pk1iqruLZZWTTh9gYDo2QX8EY_PiirVYDuwne2Upr3GlqZk570wtLOF49aaP-HQ=@gpb.moe> <eb03c51b-344f-4d6d-9e73-7e499b43a928@gmail.com> <AM8P250MB017056034C85B7785F5A7AB8E24CA@AM8P250MB0170.EURP250.PROD.OUTLOOK.COM> <CA+NMNO0wC4iLTtED9y6jWL2XkSrTH8aZ5Kd9f7arT_XA3+Lktw@mail.gmail.com>
Feedback-ID: 96993444:user:proton
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: internals@gpb.moe ("Gina P. Banyard")

On Monday, 7 July 2025 at 16:46, Eric Norris <eric.t.norris@gmail.com> wrot=
e:

> > ** Deprecate the error_prepend_string and error_append_string INI direc=
tives
> > Why is that of questionable use? Why is "this is a development and debu=
gging feature" considered a valid reason to get rid of something? It allows=
 prominently displaying issues in development when they would be hidden beh=
ind other HTML otherwise.
>=20
>=20
> I recently made a change to the php_error_cb function for the Error
> Backtraces v2 RFC (https://wiki.php.net/rfc/error_backtraces_v2), and
> I recall that working inside that function was quite difficult. The
> error_prepend_string and error_append_string directives are a tiny
> part of the complexity there, but nonetheless removing them would
> maybe start to move us in a direction of greatly simplifying the
> implementation of php_error_cb, which I would support. I don't have
> strong feelings here, however.

I removed it as it seems my justification was not enough,
if you still think it would be worthwhile by expanding on this complexity, =
that would be great!
I do know aswell that any call to zend_error() doesn't use the docref IIRC,=
 which leads to very inconsistent styling.

Best regards,

Gina P. Banyard