Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127923
Precedence: bulk
MIME-Version: 1.0
References: <CALaXqqRKy4_y3HkO6dVhVcOjoHOp=HYdsU7v3SVZQ8kr1EfgLA@mail.gmail.com>
 <CALaXqqSyPt-Dt_RFVrERrD+MV=yVspNfGL9apA+6L6KRidx+Hw@mail.gmail.com> <1454d4c5-ab45-4522-b1c5-a418bdcbb532@bastelstu.be>
In-Reply-To: <1454d4c5-ab45-4522-b1c5-a418bdcbb532@bastelstu.be>
Date: Sun, 6 Jul 2025 10:47:27 -0700
Message-ID: <CALaXqqSoO51H7R+1NNryMHstfF8Eq3U-0qW85F16u3NR59Snjg@mail.gmail.com>
Subject: Re: [PHP-DEV] Re: [RFC] [Discussion] #[\DelayedTargetValidation] attribute
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
Cc: php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000af09b30639465383"
From: daniel.e.scherzer@gmail.com (Daniel Scherzer)

--000000000000af09b30639465383
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Jul 6, 2025 at 5:48=E2=80=AFAM Tim D=C3=BCsterhus <tim@bastelstu.be=
> wrote:

> Hi
>
> On 7/5/25 00:49, Daniel Scherzer wrote:
> > If there is no further feedback, I intend to start a vote in a few days=
.
>
> Looking at your #[\Deprecated] for traits RFC
> (https://externals.io/message/127912):
>
> How will #[\DelayedTargetValidation] interact with the `validator` of
> `zend_internal_attribute`? Would applying #[\DelayedTargetValidation] +
> #[\Deprecated] on a regular class error or not?
>
> Best regards
> Tim D=C3=BCsterhus
>


For validators, an extra flag is passed to the validator to indicate if
target validation should be disabled, in which case the errors about
targeting the wrong type of thing (e.g. a non-trait in the case of
#[\Deprecated]) are suppressed until runtime as well. Thanks for pointing
this out - I actually hadn't done this properly, fixed it now - take a look
at the "errors_from_validator.phpt" and "validator_success.phpt" test cases
in the PR.

The reasoning here is exactly the same - validators are used to verify that
an attribute is being used on things that are appropriate, just like
targets. While the only current (non-zend_test) validator is for dynamic
properties, and it is less likely that there will be a future where the
validator accepts more things, we shouldn't assume that things will never
change, e.g. I wouldn't object to allowing #[\AllowDynamicProperties] for
read-only classes. But this will also set the stage for the #[\Deprecated]
validator - that validator will enforce that a zend_class_entry is for a
trait, but if validation is delayed then it will allow using #[\Deprecated]
on interfaces or classes and the error being delaying until runtime.

-Daniel

--000000000000af09b30639465383
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Sun, Jul 6, 2025 at 5:48=E2=80=AFAM Ti=
m D=C3=BCsterhus &lt;<a href=3D"mailto:tim@bastelstu.be">tim@bastelstu.be</=
a>&gt; wrote:</div><div class=3D"gmail_quote gmail_quote_container"><blockq=
uote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1p=
x solid rgb(204,204,204);padding-left:1ex">Hi<br>
<br>
On 7/5/25 00:49, Daniel Scherzer wrote:<br>
&gt; If there is no further feedback, I intend to start a vote in a few day=
s.<br>
<br>
Looking at your #[\Deprecated] for traits RFC <br>
(<a href=3D"https://externals.io/message/127912" rel=3D"noreferrer" target=
=3D"_blank">https://externals.io/message/127912</a>):<br>
<br>
How will #[\DelayedTargetValidation] interact with the `validator` of <br>
`zend_internal_attribute`? Would applying #[\DelayedTargetValidation] + <br=
>
#[\Deprecated] on a regular class error or not?<br>
<br>
Best regards<br>
Tim D=C3=BCsterhus<br></blockquote><div><br></div><div><br></div><div>For v=
alidators, an extra flag is passed to the validator to indicate if target v=
alidation should be disabled, in which case the errors about targeting the =
wrong type of thing (e.g. a non-trait in the case of #[\Deprecated]) are su=
ppressed until runtime as well. Thanks for pointing this out - I actually h=
adn&#39;t done this properly, fixed it now - take a look at the &quot;error=
s_from_validator.phpt&quot; and &quot;validator_success.phpt&quot; test cas=
es in the PR.</div><div><br></div><div>The reasoning here is exactly=C2=A0t=
he same - validators are used to verify that an attribute is being used on =
things that are appropriate, just like targets. While the only current (non=
-zend_test) validator is for dynamic properties, and it is less likely that=
 there will be a future where the validator accepts more things, we shouldn=
&#39;t assume that things will never change, e.g. I wouldn&#39;t object to =
allowing #[\AllowDynamicProperties] for read-only classes. But this will al=
so set the stage for the #[\Deprecated] validator - that validator will enf=
orce that a zend_class_entry is for a trait, but if validation is delayed t=
hen it will allow using #[\Deprecated] on interfaces or classes and the err=
or being delaying until runtime.</div><div><br></div><div>-Daniel</div></di=
v></div>

--000000000000af09b30639465383--