Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127919
Message-ID: <14fe09eb-f33f-40eb-b850-358dbe20f364@bastelstu.be>
Date: Sun, 6 Jul 2025 15:45:04 +0200
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PHP-DEV] [RFC] Deprecations for PHP 8.5
To: Ilija Tovilo <tovilo.ilija@gmail.com>,
 PHP internals <internals@lists.php.net>
References: <hzKdzBWWITU1ePjv3qcyK-OzroFAkWst9MQBw2zvKSA8pk1iqruLZZWTTh9gYDo2QX8EY_PiirVYDuwne2Upr3GlqZk570wtLOF49aaP-HQ=@gpb.moe>
 <CAPyj-LCwNznKQVpEQEiCPirMK5Xh+p9CFkhx8C68-3iUT09Bvg@mail.gmail.com>
Content-Language: en-US
In-Reply-To: <CAPyj-LCwNznKQVpEQEiCPirMK5Xh+p9CFkhx8C68-3iUT09Bvg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

On 7/3/25 16:45, Ilija Tovilo wrote:
>> Deprecate passing spl_autoload_call() to spl_autoload_unregister()
> 
> Is such a check actually useful? We can prevent
> spl_autoload_unregister(spl_autoload_call(...)), but we can't prevent
> spl_autoload_unregister(fn($c) => spl_autoload_call($c)). It seems
> very unlikely for this to happen accidentally, and excluding all
> functions that don't make sense to pass is not feasible for obvious
> reasons. But I don't care too much.

See also my reply to Niels. Such a check already exists:

https://github.com/php/php-src/blob/677a1f80c86b7a5848985bf44714210d0b89900b/ext/spl/php_spl.c#L583-L590

That's an explicit special case in the language that could go away.

Best regards
Tim Düsterhus