Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127888
Precedence: bulk
MIME-Version: 1.0
References: <hzKdzBWWITU1ePjv3qcyK-OzroFAkWst9MQBw2zvKSA8pk1iqruLZZWTTh9gYDo2QX8EY_PiirVYDuwne2Upr3GlqZk570wtLOF49aaP-HQ=@gpb.moe>
 <CAPyj-LCwNznKQVpEQEiCPirMK5Xh+p9CFkhx8C68-3iUT09Bvg@mail.gmail.com>
In-Reply-To: <CAPyj-LCwNznKQVpEQEiCPirMK5Xh+p9CFkhx8C68-3iUT09Bvg@mail.gmail.com>
Date: Fri, 4 Jul 2025 15:20:57 -0700
Message-ID: <CALaXqqRemCX65=0wqxQG0BE0SpNXx1fhBjoPg2u0EPewo3bjvg@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] Deprecations for PHP 8.5
To: Ilija Tovilo <tovilo.ilija@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000062a6d6063921ea77"
From: daniel.e.scherzer@gmail.com (Daniel Scherzer)

--00000000000062a6d6063921ea77
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Jul 4, 2025 at 3:17=E2=80=AFPM Ilija Tovilo <tovilo.ilija@gmail.com=
> wrote:

> Hi everyone
>
> On Wed, Jul 2, 2025 at 9:58=E2=80=AFPM Gina P. Banyard <internals@gpb.moe=
> wrote:
> >
> > It is this time of year again where we proposed a list of deprecations
> to add in PHP 8.5:
> >
> > https://wiki.php.net/rfc/deprecations_php_8_5
>
> > Deprecate ReflectionClass::getConstant() for missing constants
>
> I don't have strong opinions on this change. However,
> ReflectionProperty::getDefaultValue() suffers from a very similar
> issue, except that it returns null rather than false
> (https://3v4l.org/G2R3l). It would make sense to avoid more
> inconsistencies. For example, ReflectionParameter::getDefaultValue()
> does throw if the parameter has no default value.
>
>

Good catch, I wasn't aware of this behavior for
`ReflectionProperty::getDefaultValue()`. I agree that we should avoid such
inconsistencies, and thus have proposed deprecating
ReflectionProperty::getDefaultValue() for properties that have no default
value. See
https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_reflectionpropertyg=
etdefaultvalue_for_properties_without_default_values

-Daniel

--00000000000062a6d6063921ea77
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Fri, Jul 4, 2025 at 3:17=E2=80=AFPM Il=
ija Tovilo &lt;<a href=3D"mailto:tovilo.ilija@gmail.com">tovilo.ilija@gmail=
.com</a>&gt; wrote:</div><div class=3D"gmail_quote gmail_quote_container"><=
blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l=
eft:1px solid rgb(204,204,204);padding-left:1ex">Hi everyone<br>
<br>
On Wed, Jul 2, 2025 at 9:58=E2=80=AFPM Gina P. Banyard &lt;internals@gpb.mo=
e&gt; wrote:<br>
&gt;<br>
&gt; It is this time of year again where we proposed a list of deprecations=
 to add in PHP 8.5:<br>
&gt;<br>
&gt; <a href=3D"https://wiki.php.net/rfc/deprecations_php_8_5" rel=3D"noref=
errer" target=3D"_blank">https://wiki.php.net/rfc/deprecations_php_8_5</a><=
br><br>
&gt; Deprecate ReflectionClass::getConstant() for missing constants<br>
<br>
I don&#39;t have strong opinions on this change. However,<br>
ReflectionProperty::getDefaultValue() suffers from a very similar<br>
issue, except that it returns null rather than false<br>
(<a href=3D"https://3v4l.org/G2R3l" rel=3D"noreferrer" target=3D"_blank">ht=
tps://3v4l.org/G2R3l</a>). It would make sense to avoid more<br>
inconsistencies. For example, ReflectionParameter::getDefaultValue()<br>
does throw if the parameter has no default value.<br><br></blockquote><div>=
<br></div><div><br></div><div>Good catch, I wasn&#39;t aware of this behavi=
or for `ReflectionProperty::getDefaultValue()`. I agree that we should avoi=
d such inconsistencies, and thus have proposed deprecating ReflectionProper=
ty::getDefaultValue() for properties that have no default value. See=C2=A0<=
a href=3D"https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_reflectio=
npropertygetdefaultvalue_for_properties_without_default_values">https://wik=
i.php.net/rfc/deprecations_php_8_5#deprecate_reflectionpropertygetdefaultva=
lue_for_properties_without_default_values</a></div><div><br></div><div>-Dan=
iel</div></div></div>

--00000000000062a6d6063921ea77--