Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127886
Precedence: bulk
MIME-Version: 1.0
References: <CAEKnhAF3KOGcWZ6CYxpWkpZbNOGo79DD7p=WsAoJvqdJ5xG_Uw@mail.gmail.com>
 <CAPyeZ4NuyVmzJ2W_8Ayy=mrY+9nURqMa9JKJfXyTSV9FsFGNuA@mail.gmail.com>
In-Reply-To: <CAPyeZ4NuyVmzJ2W_8Ayy=mrY+9nURqMa9JKJfXyTSV9FsFGNuA@mail.gmail.com>
Date: Sat, 5 Jul 2025 00:11:25 +0200
Message-ID: <CAEKnhAHW1NETKdk67OBhvVpywhy5njgMOXBFOPaj-givbZEZYQ@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] JSON Schema validation support
To: Valentin Udaltsov <udaltsov.valentin@gmail.com>
Cc: PHP internals list <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000198810063921c7eb"
From: bukka@php.net (Jakub Zelenka)

--000000000000198810063921c7eb
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On Fri, Jul 4, 2025 at 11:49=E2=80=AFPM Valentin Udaltsov <
udaltsov.valentin@gmail.com> wrote:

> On Sta, 5 July 2025=E2=80=AFat 00:04, Jakub Zelenka <bukka@php.net> wrote=
:
>
>> Hello,
>>
>> I would like introduce and open discussion for RFC proposing the additio=
n
>> of JSON Schema validation support to JSON extension:
>>
>> https://wiki.php.net/rfc/json_schema_validation
>>
>> If this is successful, it should be just the first for further
>> improvements (see the future scope).
>>
>> Kind regards,
>>
>> Jakub
>>
>
> Hi, Jakub!
>
> I like the idea. I have a couple of initial thoughts:
>
> 1. Wouldn't it make sense to place all the new classes under the `Json`
> namespace, similar to how it=E2=80=99s done in `ext-random`?
>

This would be widely inconsistent with the current interface / exception
class in the extension. The ext-random was a new extension so it's a
completely different case. I think it makes much more sense to keep the
extension consistent than introducing new interface.


> 2. If there=E2=80=99s no way to interact with the `JsonSchema` class, wha=
t purpose
> does it serve? Wouldn=E2=80=99t it be simpler to just extend `json_decode=
()` with
> an optional `?string $schema =3D null` parameter?
>

There are couple of reasons for this:

- It allows re-using the same parsed schema without a need to parse it
multiple times for each decoding / validation - the class internally holds
parsed representation of the schema.
- We might want to introduce additional flags that will impact the parsing
(e.g. default version)
- It might allow a way to better cache schema between requests so it could
further improve performance in the future
- It will allow the possibility to get schema from other sources than
string - e.g. from PHP array or even automatic creation from the class
(that's why the JsonSchema is created using static method and not using
constructor). This might be especially useful for object mapping.

Kind regards,

Jakub

--000000000000198810063921c7eb
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi,</div><br><div class=3D"gmail_quote gmail_quote_co=
ntainer"><div dir=3D"ltr" class=3D"gmail_attr">On Fri, Jul 4, 2025 at 11:49=
=E2=80=AFPM Valentin Udaltsov &lt;<a href=3D"mailto:udaltsov.valentin@gmail=
.com">udaltsov.valentin@gmail.com</a>&gt; wrote:<br></div><blockquote class=
=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg=
b(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div>On Sta, 5 July 2025=
=E2=80=AFat 00:04, Jakub Zelenka &lt;<a href=3D"mailto:bukka@php.net" targe=
t=3D"_blank">bukka@php.net</a>&gt; wrote:</div><div class=3D"gmail_quote"><=
blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l=
eft:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">Hello,<di=
v><br></div><div>I would like introduce and open discussion for RFC proposi=
ng the addition of JSON Schema validation support to JSON extension:</div><=
div><br></div><div><a href=3D"https://wiki.php.net/rfc/json_schema_validati=
on" target=3D"_blank">https://wiki.php.net/rfc/json_schema_validation</a></=
div><div><br></div><div>If this is successful, it should be just the first =
for further improvements (see the future scope).</div><div><br></div><div>K=
ind regards,</div><div><br></div><div>Jakub</div></div>
</blockquote></div><div><br>Hi, Jakub!<br><br>I like the idea. I have a cou=
ple of initial thoughts:<br><br>1. Wouldn&#39;t it make sense to place all =
the new classes under the `Json` namespace, similar to how it=E2=80=99s don=
e in `ext-random`?</div></div></blockquote><div><br></div><div>This would b=
e widely inconsistent with the current interface / exception class in the e=
xtension. The ext-random was a new extension so it&#39;s a completely diffe=
rent case. I think it makes much more sense to keep the extension consisten=
t than introducing new interface.</div><div>=C2=A0</div><blockquote class=
=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg=
b(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div>2. If there=E2=80=99=
s no way to interact with the `JsonSchema` class, what purpose does it serv=
e? Wouldn=E2=80=99t it be simpler to just extend `json_decode()` with an op=
tional `?string $schema =3D null` parameter?</div></div></blockquote><div><=
br></div><div>There are couple of reasons for this:</div><div><br></div><di=
v>- It allows re-using the same parsed schema without a need to parse it mu=
ltiple times for each decoding / validation - the class internally holds pa=
rsed representation of the schema.</div><div>- We might want to introduce a=
dditional flags that will impact the parsing (e.g. default version)</div><d=
iv>- It might allow a way to better cache schema between requests so it cou=
ld further improve performance in the future</div><div>- It will allow the =
possibility to get schema from other sources than string - e.g. from PHP ar=
ray or even automatic creation from the class (that&#39;s why the JsonSchem=
a=C2=A0is created using static method and not using constructor). This migh=
t be especially useful for object mapping.</div><div><br></div><div>Kind re=
gards,</div><div><br></div><div>Jakub</div><div><br></div></div></div>

--000000000000198810063921c7eb--