Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127815
Precedence: bulk
MIME-Version: 1.0
Date: Tue, 01 Jul 2025 10:33:48 +0200
To: Adam Cable <adamcable@gmail.com>
Cc: php internals <internals@lists.php.net>
Subject: Re: [PHP-DEV] [VOTE] str_icontains
In-Reply-To: <CADuktwNM_-RMLeSN79QAV-PN1gFcuyEk178D0O56Ge=osLS1+Q@mail.gmail.com>
References: <CADuktwOxg-qBjFRZmHTQ1SwJMh==4WxC9sNmpLfCh78Ht84OJw@mail.gmail.com>
 <0e13771dc08c4a7d880c1fff46d21bf0@bastelstu.be>
 <CADuktwNM_-RMLeSN79QAV-PN1gFcuyEk178D0O56Ge=osLS1+Q@mail.gmail.com>
Message-ID: <93d54094168d4c7ef98eb32336cdc5d0@bastelstu.be>
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

Am 2025-07-01 10:17, schrieb Adam Cable:
> Thanks for giving an explanation of your vote, thank you.
> I had assumed that going with a small RFC for this would be easier than
> trying to get str_starts/ends_with through at the same time, as noted 
> in
> the PR:
> 
> "I'll create a RFC for this, and if successful look to do the same with
> str_starts_with and str_ends_with"

I generally prefer splitting RFCs into its “atomic parts” that make 
sense on its own, since that makes it easier to discuss the RFC and 
ensures that features compose well.

However in this case, the other functions are *so similar* in practice 
that it would make sense to handle them all at the same time, including 
figuring out naming / the bigger picture. Otherwise we might end up with 
`str_icontains()`  and `stri_starts_with()` (since `str_istarts_with()` 
is ugly by the folks discussing the next RFC) - which clearly is 
undesirable.

Best regards
Tim Düsterhus