Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127813
Precedence: bulk
MIME-Version: 1.0
References: <CADuktwOxg-qBjFRZmHTQ1SwJMh==4WxC9sNmpLfCh78Ht84OJw@mail.gmail.com>
 <0e13771dc08c4a7d880c1fff46d21bf0@bastelstu.be>
In-Reply-To: <0e13771dc08c4a7d880c1fff46d21bf0@bastelstu.be>
Date: Tue, 1 Jul 2025 09:17:12 +0100
Message-ID: <CADuktwNM_-RMLeSN79QAV-PN1gFcuyEk178D0O56Ge=osLS1+Q@mail.gmail.com>
Subject: Re: [PHP-DEV] [VOTE] str_icontains
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
Cc: php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000034fa4c0638d9c6c7"
From: adamcable@gmail.com (Adam Cable)

--00000000000034fa4c0638d9c6c7
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Jul 1, 2025 at 8:24=E2=80=AFAM Tim D=C3=BCsterhus <tim@bastelstu.be=
> wrote:

> Hi
>
> Am 2025-07-01 09:01, schrieb Adam Cable:
> > Voting just opened on the "str_icontains" RFC.
> >
> > Please find the following resources:
> >
> > RFC: https://wiki.php.net/rfc/str_icontains
> > Discussion: https://externals.io/message/127667
> > PR: https://github.com/php/php-src/pull/18705
>
> Thank you for your RFC. While I initially said =E2=80=9Cseems easy enough=
=E2=80=9D in
> the PR and I also believe that making the function ASCII-only for
> consistency, I ultimately decided to vote against the RFC.
>
> My main reason is that I do not like how this function is added in a
> standalone fashion without a bigger picture. As mentioned in the PR,
> `str_starts_with()` and `str_ends_with()` are obvious companion
> functions.
>
> And ultimately calling `strtolower()` on both parameters before passing
> them to `str_contains()` is quite explicit in what it does (and would
> also resolve the Unicode vs ASCII confusion that others expressed).
> Alternatively `stripos()` would also work.
>
> Best regards
> Tim D=C3=BCsterhus
>

Hi Tim,

Thanks for giving an explanation of your vote, thank you.
I had assumed that going with a small RFC for this would be easier than
trying to get str_starts/ends_with through at the same time, as noted in
the PR:

"I'll create a RFC for this, and if successful look to do the same with
str_starts_with and str_ends_with"

Thanks,
Adam

--00000000000034fa4c0638d9c6c7
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g=
mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Tue, Jul 1, =
2025 at 8:24=E2=80=AFAM Tim D=C3=BCsterhus &lt;<a href=3D"mailto:tim@bastel=
stu.be">tim@bastelstu.be</a>&gt; wrote:<br></div><blockquote class=3D"gmail=
_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204=
,204);padding-left:1ex">Hi<br>
<br>
Am 2025-07-01 09:01, schrieb Adam Cable:<br>
&gt; Voting just opened on the &quot;str_icontains&quot; RFC.<br>
&gt; <br>
&gt; Please find the following resources:<br>
&gt; <br>
&gt; RFC: <a href=3D"https://wiki.php.net/rfc/str_icontains" rel=3D"norefer=
rer" target=3D"_blank">https://wiki.php.net/rfc/str_icontains</a><br>
&gt; Discussion: <a href=3D"https://externals.io/message/127667" rel=3D"nor=
eferrer" target=3D"_blank">https://externals.io/message/127667</a><br>
&gt; PR: <a href=3D"https://github.com/php/php-src/pull/18705" rel=3D"noref=
errer" target=3D"_blank">https://github.com/php/php-src/pull/18705</a><br>
<br>
Thank you for your RFC. While I initially said =E2=80=9Cseems easy enough=
=E2=80=9D in <br>
the PR and I also believe that making the function ASCII-only for <br>
consistency, I ultimately decided to vote against the RFC.<br>
<br>
My main reason is that I do not like how this function is added in a <br>
standalone fashion without a bigger picture. As mentioned in the PR, <br>
`str_starts_with()` and `str_ends_with()` are obvious companion <br>
functions.<br>
<br>
And ultimately calling `strtolower()` on both parameters before passing <br=
>
them to `str_contains()` is quite explicit in what it does (and would <br>
also resolve the Unicode vs ASCII confusion that others expressed). <br>
Alternatively `stripos()` would also work.<br>
<br>
Best regards<br>
Tim D=C3=BCsterhus<br></blockquote><div><br></div><div>Hi Tim,</div><div><b=
r></div><div>Thanks for giving an explanation of your vote, thank you.</div=
><div>I had assumed that going with a small RFC for this would be easier th=
an trying to get str_starts/ends_with through at the same time, as noted in=
 the PR:</div><div><br></div><div>&quot;I&#39;ll create a RFC for this, and=
 if successful look to do the same with str_starts_with and str_ends_with&q=
uot;</div><div><br></div><div>Thanks,</div><div>Adam=C2=A0</div></div></div=
>

--00000000000034fa4c0638d9c6c7--