Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127811
Precedence: bulk
MIME-Version: 1.0
Date: Tue, 01 Jul 2025 09:24:26 +0200
To: Adam Cable <adamcable@gmail.com>
Cc: php internals <internals@lists.php.net>
Subject: Re: [PHP-DEV] [VOTE] str_icontains
In-Reply-To: <CADuktwOxg-qBjFRZmHTQ1SwJMh==4WxC9sNmpLfCh78Ht84OJw@mail.gmail.com>
References: <CADuktwOxg-qBjFRZmHTQ1SwJMh==4WxC9sNmpLfCh78Ht84OJw@mail.gmail.com>
Message-ID: <0e13771dc08c4a7d880c1fff46d21bf0@bastelstu.be>
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

Am 2025-07-01 09:01, schrieb Adam Cable:
> Voting just opened on the "str_icontains" RFC.
> 
> Please find the following resources:
> 
> RFC: https://wiki.php.net/rfc/str_icontains
> Discussion: https://externals.io/message/127667
> PR: https://github.com/php/php-src/pull/18705

Thank you for your RFC. While I initially said “seems easy enough” in 
the PR and I also believe that making the function ASCII-only for 
consistency, I ultimately decided to vote against the RFC.

My main reason is that I do not like how this function is added in a 
standalone fashion without a bigger picture. As mentioned in the PR, 
`str_starts_with()` and `str_ends_with()` are obvious companion 
functions.

And ultimately calling `strtolower()` on both parameters before passing 
them to `str_contains()` is quite explicit in what it does (and would 
also resolve the Unicode vs ASCII confusion that others expressed). 
Alternatively `stripos()` would also work.

Best regards
Tim Düsterhus