Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127768
Message-ID: <e52fa8b0-31c7-4280-9d6f-8cb5578a4dce@seld.be>
Date: Fri, 27 Jun 2025 14:22:05 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] [RFC][DISCUSSION] Object-oriented curl API v2
To: erictnorris@gmail.com, PHP internals <internals@lists.php.net>
References: <CA+NMNO0K85acCismdBL=8vr5=nKg1_-i0BjXyiqnjoqGAnH3Xw@mail.gmail.com>
Content-Language: fr
In-Reply-To: <CA+NMNO0K85acCismdBL=8vr5=nKg1_-i0BjXyiqnjoqGAnH3Xw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: j.boggiano@seld.be (Jordi Boggiano)

On 26.06.2025 18:25, Eric Norris wrote:
> - uses enumerations for curl options and other curl constants

Overall I think the RFC is a good opportunity to clean up a few legacy 
oddities in the curl API, but I need to throw in my 2c about enum usage 
here, as someone that has actually implemented some complexish 
curl-based client [1].

Currently the API is:

     curl_setopt($h, CURLOPT_SMTH, 3);

Now moving this into multiple enums to me brings one major issue, that I 
first have to think about which type the option has to then know on 
which enum I find it.

I understand this brings type safety on the value side if you have 
multiple setOptionInt etc, but that does not seem worth the trade-off to 
me. Type safety can already be done in static analyzers as they can see 
which option you pass in, they know which value should be allowed.

Then on top of that, assuming we'd put all options in one enum.. I am 
still wondering what the added value is compared to simply having the 
global constants (they could be namespaced if anything...). It's longer 
to type, and does not provide any better autocompletion. 
\Curl\Option::ConnectTimeout vs CURLOPT_CONNECT_TIMEOUT sounds ok to me 
if people feel strongly pro-enum, but I do really hope it is then a 
single enum + setOption() call.

Best,
Jordi

[1] 
https://github.com/composer/composer/blob/main/src/Composer/Util/Http/CurlDownloader.php

Jordi Boggiano
@seldaek - https://seld.be