Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:12776 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 24994 invoked by uid 1010); 13 Sep 2004 18:47:51 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 5861 invoked from network); 13 Sep 2004 18:45:18 -0000 Received: from unknown (HELO jdi.jdimedia.nl) (212.204.192.51) by pb1.pair.com with SMTP; 13 Sep 2004 18:45:18 -0000 Received: from localhost (localhost [127.0.0.1]) by jdi.jdimedia.nl (8.12.11/8.12.11) with ESMTP id i8DIjHu5003853 for ; Mon, 13 Sep 2004 20:45:17 +0200 Received: from localhost (localhost [127.0.0.1]) by jdi.jdimedia.nl (8.12.11/8.12.11) with ESMTP id i8DIjCUn003821; Mon, 13 Sep 2004 20:45:12 +0200 Date: Mon, 13 Sep 2004 20:45:12 +0200 (CEST) X-X-Sender: derick@localhost To: Steph cc: internals In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by amavisd-new at jdimedia.nl Subject: Re: [PHP-DEV] [PATCH] ok this works in all cases and smells right From: derick@php.net (Derick Rethans) On Mon, 13 Sep 2004, Steph wrote: > BTW shouldn't main/config.w32.h be in .cvsignore? This patch is wrong, the #if HAVE_STRCOLL should be there in all places, also, I did not guard the constant registration as that can always be available just fine. Derick -- Derick Rethans http://derickrethans.nl | http://ez.no | http://xdebug.org