Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127755
Precedence: bulk
MIME-Version: 1.0
References: <YaJrvr69GYjTEI8_yULnrtV4XjfR2tfQIBBGtJrLH_dO62WsKXcmMdUCk-FaPMIilVRlQWX5BZleaxBcCinSwmfMnJR_-whG2jLSflKN85E=@gpb.moe>
 <CAGBsUrfnwPcq1Ot3A_DDWMxMQ6mPabOiZ7JcBQNQyHpD9JP-Ug@mail.gmail.com>
In-Reply-To: <CAGBsUrfnwPcq1Ot3A_DDWMxMQ6mPabOiZ7JcBQNQyHpD9JP-Ug@mail.gmail.com>
Date: Wed, 25 Jun 2025 17:19:23 +0300
Message-ID: <CAAwdEzCGbXKw2zTd+3-tYujxCqAEGYvDUAd_TqzYOhfLAS=dgw@mail.gmail.com>
Subject: Re: [PHP-DEV] Make Reflection*::getDocComment() return an empty
 string instead of false
To: Kamil Tekiela <tekiela246@gmail.com>
Cc: "Gina P. Banyard" <internals@gpb.moe>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000f768930638662254"
From: drealecs@gmail.com (=?UTF-8?Q?Alexandru_P=C4=83tr=C4=83nescu?=)

--000000000000f768930638662254
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 25, 2025 at 4:22=E2=80=AFPM Kamil Tekiela <tekiela246@gmail.com=
> wrote:

> What exactly is the context in which symfony uses it?
>

Was wondering just that, and I can only imagine it's a function call that
receives the parameter as a string and it would  getDocComment() result is
passed directly, sometimes being false.
Example:
https://github.com/symfony/symfony/blob/a3c1d1f9e9bbac9933cc3792a55e756eca5=
bb495/src/Symfony/Component/DependencyInjection/ContainerBuilder.php#L1177

I think that for those cases `getDocComment() :? ''` might be a faster fix
and move on with it.
And symfony already does this in some places:
https://github.com/symfony/symfony/blob/a3c1d1f9e9bbac9933cc3792a55e756eca5=
bb495/src/Symfony/Component/DependencyInjection/Compiler/AutowireRequiredMe=
thodsPass.php#L53

IMHO, it's not worth the compatibility breakage, as some others might
already compare it using `=3D=3D=3D false`.

--=20
Alex

--000000000000f768930638662254
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div><div><br></div></div></div><br><div =
class=3D"gmail_quote gmail_quote_container"><div dir=3D"ltr" class=3D"gmail=
_attr">On Wed, Jun 25, 2025 at 4:22=E2=80=AFPM Kamil Tekiela &lt;<a href=3D=
"mailto:tekiela246@gmail.com">tekiela246@gmail.com</a>&gt; wrote:<br></div>=
<blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-=
left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"auto">What ex=
actly is the context in which symfony uses it?</div></blockquote><div><br><=
/div><div>Was wondering just that, and I can only imagine it&#39;s a functi=
on call that receives the parameter as a string and it would=C2=A0 getDocCo=
mment() result is passed directly, sometimes being false.<div>Example:=C2=
=A0<a href=3D"https://github.com/symfony/symfony/blob/a3c1d1f9e9bbac9933cc3=
792a55e756eca5bb495/src/Symfony/Component/DependencyInjection/ContainerBuil=
der.php#L1177">https://github.com/symfony/symfony/blob/a3c1d1f9e9bbac9933cc=
3792a55e756eca5bb495/src/Symfony/Component/DependencyInjection/ContainerBui=
lder.php#L1177</a></div><div><br><div>I think that for those cases `getDocC=
omment() :? &#39;&#39;` might be a faster fix and move on with it.</div><di=
v>And symfony already does this in some places:=C2=A0<a href=3D"https://git=
hub.com/symfony/symfony/blob/a3c1d1f9e9bbac9933cc3792a55e756eca5bb495/src/S=
ymfony/Component/DependencyInjection/Compiler/AutowireRequiredMethodsPass.p=
hp#L53">https://github.com/symfony/symfony/blob/a3c1d1f9e9bbac9933cc3792a55=
e756eca5bb495/src/Symfony/Component/DependencyInjection/Compiler/AutowireRe=
quiredMethodsPass.php#L53</a></div><div><br></div><div>IMHO, it&#39;s not w=
orth the compatibility breakage, as some others might already compare it us=
ing `=3D=3D=3D false`.</div><div><br></div><div>--=C2=A0</div><div>Alex</di=
v></div></div><div>=C2=A0</div></div></div>

--000000000000f768930638662254--