Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127750
Precedence: bulk
MIME-Version: 1.0
References: <YaJrvr69GYjTEI8_yULnrtV4XjfR2tfQIBBGtJrLH_dO62WsKXcmMdUCk-FaPMIilVRlQWX5BZleaxBcCinSwmfMnJR_-whG2jLSflKN85E=@gpb.moe>
In-Reply-To: <YaJrvr69GYjTEI8_yULnrtV4XjfR2tfQIBBGtJrLH_dO62WsKXcmMdUCk-FaPMIilVRlQWX5BZleaxBcCinSwmfMnJR_-whG2jLSflKN85E=@gpb.moe>
Date: Wed, 25 Jun 2025 13:43:28 +0100
Message-ID: <CA+XhMqzQ9VtAXO2RSScy-bz_oDRUM6dp5OAuQAbiQLPh4SbKtg@mail.gmail.com>
Subject: Re: [PHP-DEV] Make Reflection*::getDocComment() return an empty
 string instead of false
To: "Gina P. Banyard" <internals@gpb.moe>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000005ed256063864cbfc"
From: devnexen@gmail.com (David CARLIER)

--0000000000005ed256063864cbfc
Content-Type: text/plain; charset="UTF-8"

Hi,

It makes more sense to me too to change this behavior. I would rather go
with null though ; but that is just personal preference ; empty string is
already better than false ... Did you assess how widely it is used before
the users come back "angry" ?

Cheers.

On Wed, 25 Jun 2025 at 11:39, Gina P. Banyard <internals@gpb.moe> wrote:

> Hello internals,
>
> While working on the deprecation to/from bool type juggling in functions
> RFC and seeing the impact within Symfony, we found a common slightly
> annoying case.
> The getDocComment method of various Reflection classes was always used as
> a string, and we thought changing the behaviour in PHP made more sense.
>
> I submitted a PR [1] but was asked to gather feedback on the mailing list.
>
> Please let me know what you think.
>
> Best regards,
>
> Gina P. Banyard
>
> [1] https://github.com/php/php-src/pull/18928
>

--0000000000005ed256063864cbfc
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi,<div><br></div><div>It makes more sense to me too to ch=
ange this behavior. I would rather go with null though ; but that is just p=
ersonal preference ; empty string is already better than false ... Did you =
assess how widely it is used before the users come back &quot;angry&quot; ?=
</div><div><br></div><div>Cheers.</div></div><br><div class=3D"gmail_quote =
gmail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Wed, 25 Jun=
 2025 at 11:39, Gina P. Banyard &lt;internals@gpb.moe&gt; wrote:<br></div><=
blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l=
eft:1px solid rgb(204,204,204);padding-left:1ex">Hello internals,<br>
<br>
While working on the deprecation to/from bool type juggling in functions RF=
C and seeing the impact within Symfony, we found a common slightly annoying=
 case.<br>
The getDocComment method of various Reflection classes was always used as a=
 string, and we thought changing the behaviour in PHP made more sense.<br>
<br>
I submitted a PR [1] but was asked to gather feedback on the mailing list.<=
br>
<br>
Please let me know what you think.<br>
<br>
Best regards,<br>
<br>
Gina P. Banyard<br>
<br>
[1] <a href=3D"https://github.com/php/php-src/pull/18928" rel=3D"noreferrer=
" target=3D"_blank">https://github.com/php/php-src/pull/18928</a><br>
</blockquote></div>

--0000000000005ed256063864cbfc--