Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:127747 X-Original-To: internals@lists.php.net Delivered-To: internals@lists.php.net Received: from php-smtp4.php.net (php-smtp4.php.net [45.112.84.5]) by lists.php.net (Postfix) with ESMTPS id 5F85A1A00BC for ; Wed, 25 Jun 2025 10:37:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=php.net; s=mail; t=1750847752; bh=e/GPzBccAOwb76pXoHDTHYNlN/AX5xc0AGVA6GWVwiw=; h=Date:To:From:Subject:From; b=XsseDWIUCoewOpe4lc7UaYqXQPxUvbj0/7BczCH6oZUW9XxNNvW1vK4f6Uxr+ddpR n2R59dhs/wprmxZSg6sLTr9d0XObhR0B/duSfJK5Na2Qd1UHU/2sCD2Y+V5d0iGQ1z EVh3IOnUugnj1rRgC8h/GSCmhSPp00G3QfVo6fo2jDzLfukTHqcVfEkBAm5zmZyPaz iXB9MXCvrvBEU//gWpOM5Ikwi5gyN0HrKxcvQCL26ahbtm4yJl0H/+NCwj4Nu4EnS1 4BVW2lcj5KLsSjA231Ph12f/azKUafSJehxiJ+TTqZB/k6k6qn7hb5bgW3LTkJKkiW l0vDrJRJSGyYg== Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 7FB5A1801C7 for ; Wed, 25 Jun 2025 10:35:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_20,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,DMARC_PASS,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS autolearn=no autolearn_force=no version=4.0.1 X-Spam-Virus: Error (Cannot connect to unix socket '/var/run/clamav/clamd.ctl': connect: Connection refused) X-Envelope-From: Received: from mail-24422.protonmail.ch (mail-24422.protonmail.ch [109.224.244.22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Wed, 25 Jun 2025 10:35:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gpb.moe; s=protonmail3; t=1750847862; x=1751107062; bh=e/GPzBccAOwb76pXoHDTHYNlN/AX5xc0AGVA6GWVwiw=; h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=hDmk6Xwx4oFYy1oaCudZl3ZdvoBi05MU1xwFUCoSJ93TYC+WqqtTr1Yrupj/9ISnr EUmIDEU915dTML9wMLPl2z75RTCgS+vB8rA4sIdOydwiLJMmF4eudYZGgCl0b1VEpu dL4gpMW8cX6CcEU+oePu6M1yMibUAtnA9r3Q7zstjNWCKKjzE5aBTSktW2iWxy3tAL i5kSnOPUdYeGDP78uPpJbLCx8gKQX85ro/spuHZLFHFKphQ7c8gZo8cKh29DJAMZWF f6qMZqNXasaD2esKV17mWezDUSYQbDqtzwe2k+ARGAr0P2gpSiBY5KeqoXGfqj+iWQ hw7DcSC5BjCoQ== Date: Wed, 25 Jun 2025 10:37:37 +0000 To: PHP internals Subject: [PHP-DEV] Make Reflection*::getDocComment() return an empty string instead of false Message-ID: Feedback-ID: 96993444:user:proton X-Pm-Message-ID: 7f1bb6b00eedf309574f1387e4eefb5638cb9e6e Precedence: bulk list-help: list-post: List-Id: internals.lists.php.net x-ms-reactions: disallow MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: internals@gpb.moe ("Gina P. Banyard") Hello internals, While working on the deprecation to/from bool type juggling in functions RF= C and seeing the impact within Symfony, we found a common slightly annoying= case. The getDocComment method of various Reflection classes was always used as a= string, and we thought changing the behaviour in PHP made more sense. I submitted a PR [1] but was asked to gather feedback on the mailing list. Please let me know what you think. Best regards, Gina P. Banyard [1] https://github.com/php/php-src/pull/18928