Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127745
Date: Tue, 24 Jun 2025 14:30:47 +0100
To: internals@lists.php.net, Larry Garfield <larry@garfieldtech.com>,
 php internals <internals@lists.php.net>
Subject: Re: [PHP-DEV] [RFC] str_icontains
User-Agent: K-9 Mail for Android
In-Reply-To: <6da22e12-3db2-4880-b045-6eaf68f2a24a@app.fastmail.com>
References: <CADuktwMdpd6Q6mQK7UYBpVm182iv5XQ7TWYXqetBZxQtk+WzVA@mail.gmail.com> <69ee9492-f7eb-4287-b222-41682ee41879@app.fastmail.com> <CADuktwNjhnBvLwv4tOniUMtWMD+5JuOAQakg3SoArZ9AOvzpXw@mail.gmail.com> <6da22e12-3db2-4880-b045-6eaf68f2a24a@app.fastmail.com>
Message-ID: <2A7316E2-C256-4214-B74C-892B10573C2A@php.net>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: derick@php.net (Derick Rethans)

On 24 June 2025 14:13:16 BST, Larry Garfield <larry@garfieldtech=2Ecom> wro=
te:
>On Tue, Jun 24, 2025, at 3:18 AM, Adam Cable wrote:
>> On Tue, Jun 24, 2025 at 12:20=E2=80=AFAM Larry Garfield <larry@garfield=
tech=2Ecom> wrote:
>>> On Sun, Jun 15, 2025, at 3:12 PM, Adam Cable wrote:
>>> > Hello internals,
>>> >
>>> > I'd like to present my first RFC - str_icontains, a case-insensitive=
=20
>>> > friend of str_contains
>>> >
>>> > RFC: https://wiki=2Ephp=2Enet/rfc/str_icontains
>>> > PR (including tests): https://github=2Ecom/php/php-src/pull/18705
>>> >
>>> > Previous discussion: https://externals=2Eio/message/127504
>>> >
>>> > Thanks,
>>> > Adam
>>>=20
>>> When str_contains() was added, a case-insensitive version was delibera=
tely omitted in favor of "just use strtolower() yourself=2E"  Have you gone=
 back to see the arguments for that to determine if they're still relevant?
>>>=20
>>> (I don't recall the details; I think one of them was function count ex=
plosion, but I think there were more=2E)
>>>=20
>>> --Larry Garfield
>>
>> Thanks Larry=2E
>>
>> Yes, I did spend time reading through the past discussions on both=20
>> str_contains and the str_starts/end_with functions=2E
>> I think initial RFCs failed because (a) people felt that the functions=
=20
>> didn't necessarily bring a whole heap of functionality above userland=
=20
>> code and (b) the debate about whether case-insensitive versions should=
=20
>> be included=2E
>>
>> Now that these functions exist, it seems weird as a PHP user that=20
>> case-insensitive versions aren't available to easily switch between=2E
>> Obviously we have the UTF-8 question that I've detailed, but I'm hoping=
=20
>> adding this will solve a tiny issue where people expect this function=
=20
>> to exist, but it doesn't=2E
>>
>> Adam
>
>A discussion of that, and why you think the new position outweighs the or=
iginal decision, should be included in the RFC=2E
>
>(At the moment I'm undecided; yeah it's an easy enough utility to add, bu=
t the UTF-8 issue is real, and one could easily argue that it's stripos() t=
hat's wrong, because it's misleading as it only works on ASCII=2E)
>
>The ideal answer would be Derick's built-in String object RFC, which I do=
n't think has been touched in a while, sadly=2E=2E=2E
>
>--Larry Garfield

That lives here, and ought to work fine as an extension for PHP 8=2E3+:

<https://github=2Ecom/derickr/php-text>

It works on graphemes, groups of Unicode code points that make up a letter=
=2E It also handles strings in multiple locales=2E

It doesn't yet have a contains method=2E

cheers
Derick