Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127744
Feedback-ID: i8414410d:Fastmail
Precedence: bulk
MIME-Version: 1.0
Date: Tue, 24 Jun 2025 08:13:16 -0500
To: "php internals" <internals@lists.php.net>
Message-ID: <6da22e12-3db2-4880-b045-6eaf68f2a24a@app.fastmail.com>
In-Reply-To: 
 <CADuktwNjhnBvLwv4tOniUMtWMD+5JuOAQakg3SoArZ9AOvzpXw@mail.gmail.com>
References: 
 <CADuktwMdpd6Q6mQK7UYBpVm182iv5XQ7TWYXqetBZxQtk+WzVA@mail.gmail.com>
 <69ee9492-f7eb-4287-b222-41682ee41879@app.fastmail.com>
 <CADuktwNjhnBvLwv4tOniUMtWMD+5JuOAQakg3SoArZ9AOvzpXw@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] str_icontains
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: larry@garfieldtech.com ("Larry Garfield")

On Tue, Jun 24, 2025, at 3:18 AM, Adam Cable wrote:
> On Tue, Jun 24, 2025 at 12:20=E2=80=AFAM Larry Garfield <larry@garfiel=
dtech.com> wrote:
>> On Sun, Jun 15, 2025, at 3:12 PM, Adam Cable wrote:
>> > Hello internals,
>> >
>> > I'd like to present my first RFC - str_icontains, a case-insensitiv=
e=20
>> > friend of str_contains
>> >
>> > RFC: https://wiki.php.net/rfc/str_icontains
>> > PR (including tests): https://github.com/php/php-src/pull/18705
>> >
>> > Previous discussion: https://externals.io/message/127504
>> >
>> > Thanks,
>> > Adam
>>=20
>> When str_contains() was added, a case-insensitive version was deliber=
ately omitted in favor of "just use strtolower() yourself."  Have you go=
ne back to see the arguments for that to determine if they're still rele=
vant?
>>=20
>> (I don't recall the details; I think one of them was function count e=
xplosion, but I think there were more.)
>>=20
>> --Larry Garfield
>
> Thanks Larry.
>
> Yes, I did spend time reading through the past discussions on both=20
> str_contains and the str_starts/end_with functions.
> I think initial RFCs failed because (a) people felt that the functions=20
> didn't necessarily bring a whole heap of functionality above userland=20
> code and (b) the debate about whether case-insensitive versions should=20
> be included.
>
> Now that these functions exist, it seems weird as a PHP user that=20
> case-insensitive versions aren't available to easily switch between.
> Obviously we have the UTF-8 question that I've detailed, but I'm hopin=
g=20
> adding this will solve a tiny issue where people expect this function=20
> to exist, but it doesn't.
>
> Adam

A discussion of that, and why you think the new position outweighs the o=
riginal decision, should be included in the RFC.

(At the moment I'm undecided; yeah it's an easy enough utility to add, b=
ut the UTF-8 issue is real, and one could easily argue that it's stripos=
() that's wrong, because it's misleading as it only works on ASCII.)

The ideal answer would be Derick's built-in String object RFC, which I d=
on't think has been touched in a while, sadly...

--Larry Garfield