Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127743
Precedence: bulk
MIME-Version: 1.0
References: <CADuktwMdpd6Q6mQK7UYBpVm182iv5XQ7TWYXqetBZxQtk+WzVA@mail.gmail.com>
 <69ee9492-f7eb-4287-b222-41682ee41879@app.fastmail.com>
In-Reply-To: <69ee9492-f7eb-4287-b222-41682ee41879@app.fastmail.com>
Date: Tue, 24 Jun 2025 09:18:03 +0100
Message-ID: <CADuktwNjhnBvLwv4tOniUMtWMD+5JuOAQakg3SoArZ9AOvzpXw@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] str_icontains
To: Larry Garfield <larry@garfieldtech.com>
Cc: php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000062cd4a06384cf8c4"
From: adamcable@gmail.com (Adam Cable)

--00000000000062cd4a06384cf8c4
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 24, 2025 at 12:20=E2=80=AFAM Larry Garfield <larry@garfieldtech=
.com>
wrote:

> On Sun, Jun 15, 2025, at 3:12 PM, Adam Cable wrote:
> > Hello internals,
> >
> > I'd like to present my first RFC - str_icontains, a case-insensitive
> > friend of str_contains
> >
> > RFC: https://wiki.php.net/rfc/str_icontains
> > PR (including tests): https://github.com/php/php-src/pull/18705
> >
> > Previous discussion: https://externals.io/message/127504
> >
> > Thanks,
> > Adam
>
> When str_contains() was added, a case-insensitive version was deliberatel=
y
> omitted in favor of "just use strtolower() yourself."  Have you gone back
> to see the arguments for that to determine if they're still relevant?
>
> (I don't recall the details; I think one of them was function count
> explosion, but I think there were more.)
>
> --Larry Garfield
>

Thanks Larry.

Yes, I did spend time reading through the past discussions on both
str_contains and the str_starts/end_with functions.
I think initial RFCs failed because (a) people felt that the functions
didn't necessarily bring a whole heap of functionality above userland code
and (b) the debate about whether case-insensitive versions should be
included.

Now that these functions exist, it seems weird as a PHP user that
case-insensitive versions aren't available to easily switch between.
Obviously we have the UTF-8 question that I've detailed, but I'm hoping
adding this will solve a tiny issue where people expect this function to
exist, but it doesn't.

Adam

--00000000000062cd4a06384cf8c4
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g=
mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Tue, Jun 24,=
 2025 at 12:20=E2=80=AFAM Larry Garfield &lt;<a href=3D"mailto:larry@garfie=
ldtech.com">larry@garfieldtech.com</a>&gt; wrote:<br></div><blockquote clas=
s=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid r=
gb(204,204,204);padding-left:1ex">On Sun, Jun 15, 2025, at 3:12 PM, Adam Ca=
ble wrote:<br>
&gt; Hello internals,<br>
&gt;<br>
&gt; I&#39;d like to present my first RFC - str_icontains, a case-insensiti=
ve <br>
&gt; friend of str_contains<br>
&gt;<br>
&gt; RFC: <a href=3D"https://wiki.php.net/rfc/str_icontains" rel=3D"norefer=
rer" target=3D"_blank">https://wiki.php.net/rfc/str_icontains</a><br>
&gt; PR (including tests): <a href=3D"https://github.com/php/php-src/pull/1=
8705" rel=3D"noreferrer" target=3D"_blank">https://github.com/php/php-src/p=
ull/18705</a><br>
&gt;<br>
&gt; Previous discussion: <a href=3D"https://externals.io/message/127504" r=
el=3D"noreferrer" target=3D"_blank">https://externals.io/message/127504</a>=
<br>
&gt;<br>
&gt; Thanks,<br>
&gt; Adam<br>
<br>
When str_contains() was added, a case-insensitive version was deliberately =
omitted in favor of &quot;just use strtolower() yourself.&quot;=C2=A0 Have =
you gone back to see the arguments for that to determine if they&#39;re sti=
ll relevant?<br>
<br>
(I don&#39;t recall the details; I think one of them was function count exp=
losion, but I think there were more.)<br>
<br>
--Larry Garfield<br></blockquote><div><br></div><div>Thanks Larry.</div><di=
v><br></div><div>Yes, I did spend time reading through the past discussions=
 on both str_contains and the=C2=A0str_starts/end_with functions.</div><div=
>I think initial RFCs failed because (a) people felt that the functions did=
n&#39;t necessarily bring a whole heap of functionality above userland code=
 and (b) the debate about whether case-insensitive versions should be inclu=
ded.</div><div><br></div><div>Now that these functions exist, it seems weir=
d as a PHP user that case-insensitive versions aren&#39;t available to easi=
ly switch between.</div><div>Obviously we have the UTF-8 question that I=
9;ve detailed, but I&#39;m hoping adding this will solve a tiny issue where=
 people expect this function to exist, but it doesn&#39;t.</div><div><br></=
div><div>Adam</div><div><br></div><div><br></div></div></div>

--00000000000062cd4a06384cf8c4--