Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127742
Precedence: bulk
MIME-Version: 1.0
References: <CADuktwMdpd6Q6mQK7UYBpVm182iv5XQ7TWYXqetBZxQtk+WzVA@mail.gmail.com>
 <69ee9492-f7eb-4287-b222-41682ee41879@app.fastmail.com> <CAEPPVa3wkw97XChEnK6dZ3iA30wg2HGEDwyAAz0rwbin9XTQjg@mail.gmail.com>
In-Reply-To: <CAEPPVa3wkw97XChEnK6dZ3iA30wg2HGEDwyAAz0rwbin9XTQjg@mail.gmail.com>
Date: Tue, 24 Jun 2025 09:12:59 +0100
Message-ID: <CADuktwPoOT2tnzn3RGyWWJs2EaoEeVQJDX6CuPnJh9oUe=D+WQ@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] str_icontains
To: youkidearitai <youkidearitai@gmail.com>
Cc: php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000005c814406384ce64c"
From: adamcable@gmail.com (Adam Cable)

--0000000000005c814406384ce64c
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 24, 2025 at 1:56=E2=80=AFAM youkidearitai <youkidearitai@gmail.=
com>
wrote:

> 2025=E5=B9=B46=E6=9C=8824=E6=97=A5(=E7=81=AB) 9:00 Larry Garfield <larry@=
garfieldtech.com>:
> >
> > On Sun, Jun 15, 2025, at 3:12 PM, Adam Cable wrote:
> > > Hello internals,
> > >
> > > I'd like to present my first RFC - str_icontains, a case-insensitive
> > > friend of str_contains
> > >
> > > RFC: https://wiki.php.net/rfc/str_icontains
> > > PR (including tests): https://github.com/php/php-src/pull/18705
> > >
> > > Previous discussion: https://externals.io/message/127504
> > >
> > > Thanks,
> > > Adam
> >
> > When str_contains() was added, a case-insensitive version was
> deliberately omitted in favor of "just use strtolower() yourself."  Have
> you gone back to see the arguments for that to determine if they're still
> relevant?
> >
> > (I don't recall the details; I think one of them was function count
> explosion, but I think there were more.)
> >
> > --Larry Garfield
>
> Hi
> I have concerns from multibyte(Unicode) user.
>
> As someone who relies on Unicode, I feel that it is not worth using
> that function.
> str_contains can matches binary, so this is benefit of many reason,
> but str_icontains is only support ASCII.
> This only benefits some regions.
>
> Regards
> Yuya
>
> --
> ---------------------------
> Yuya Hamada (tekimen)
> - https://tekitoh-memdhoi.info
> - https://github.com/youkidearitai
> -----------------------------
>


Hi Yuya,

Thanks for your message.
I totally appreciate the multibyte issue here. I've detailed about it in
the RFC.
This function is there just to help those that expect it to be available as
parity to strpos, strstr that have ASCII case-folding case-insensitive
versions available.

Thanks,
Adam

--0000000000005c814406384ce64c
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g=
mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Tue, Jun 24,=
 2025 at 1:56=E2=80=AFAM youkidearitai &lt;<a href=3D"mailto:youkidearitai@=
gmail.com">youkidearitai@gmail.com</a>&gt; wrote:<br></div><blockquote clas=
s=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid r=
gb(204,204,204);padding-left:1ex">2025=E5=B9=B46=E6=9C=8824=E6=97=A5(=E7=81=
=AB) 9:00 Larry Garfield &lt;<a href=3D"mailto:larry@garfieldtech.com" targ=
et=3D"_blank">larry@garfieldtech.com</a>&gt;:<br>
&gt;<br>
&gt; On Sun, Jun 15, 2025, at 3:12 PM, Adam Cable wrote:<br>
&gt; &gt; Hello internals,<br>
&gt; &gt;<br>
&gt; &gt; I&#39;d like to present my first RFC - str_icontains, a case-inse=
nsitive<br>
&gt; &gt; friend of str_contains<br>
&gt; &gt;<br>
&gt; &gt; RFC: <a href=3D"https://wiki.php.net/rfc/str_icontains" rel=3D"no=
referrer" target=3D"_blank">https://wiki.php.net/rfc/str_icontains</a><br>
&gt; &gt; PR (including tests): <a href=3D"https://github.com/php/php-src/p=
ull/18705" rel=3D"noreferrer" target=3D"_blank">https://github.com/php/php-=
src/pull/18705</a><br>
&gt; &gt;<br>
&gt; &gt; Previous discussion: <a href=3D"https://externals.io/message/1275=
04" rel=3D"noreferrer" target=3D"_blank">https://externals.io/message/12750=
4</a><br>
&gt; &gt;<br>
&gt; &gt; Thanks,<br>
&gt; &gt; Adam<br>
&gt;<br>
&gt; When str_contains() was added, a case-insensitive version was delibera=
tely omitted in favor of &quot;just use strtolower() yourself.&quot;=C2=A0 =
Have you gone back to see the arguments for that to determine if they&#39;r=
e still relevant?<br>
&gt;<br>
&gt; (I don&#39;t recall the details; I think one of them was function coun=
t explosion, but I think there were more.)<br>
&gt;<br>
&gt; --Larry Garfield<br>
<br>
Hi<br>
I have concerns from multibyte(Unicode) user.<br>
<br>
As someone who relies on Unicode, I feel that it is not worth using<br>
that function.<br>
str_contains can matches binary, so this is benefit of many reason,<br>
but str_icontains is only support ASCII.<br>
This only benefits some regions.<br>
<br>
Regards<br>
Yuya<br>
<br>
-- <br>
---------------------------<br>
Yuya Hamada (tekimen)<br>
- <a href=3D"https://tekitoh-memdhoi.info" rel=3D"noreferrer" target=3D"_bl=
ank">https://tekitoh-memdhoi.info</a><br>
- <a href=3D"https://github.com/youkidearitai" rel=3D"noreferrer" target=3D=
"_blank">https://github.com/youkidearitai</a><br>
-----------------------------<br></blockquote><div><br></div><div><br></div=
><div>Hi Yuya,</div><div><br></div><div>Thanks for your message.</div><div>=
I totally appreciate the multibyte issue here. I&#39;ve detailed about it i=
n the RFC.</div><div>This function is there just to help those that expect =
it to be available as parity to strpos, strstr that have ASCII case-folding=
 case-insensitive versions available.</div><div><br></div><div>Thanks,</div=
><div>Adam</div><div>=C2=A0</div></div></div>

--0000000000005c814406384ce64c--