Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127741
Precedence: bulk
MIME-Version: 1.0
References: <CADuktwMdpd6Q6mQK7UYBpVm182iv5XQ7TWYXqetBZxQtk+WzVA@mail.gmail.com>
 <69ee9492-f7eb-4287-b222-41682ee41879@app.fastmail.com>
In-Reply-To: <69ee9492-f7eb-4287-b222-41682ee41879@app.fastmail.com>
Date: Tue, 24 Jun 2025 09:55:37 +0900
Message-ID: <CAEPPVa3wkw97XChEnK6dZ3iA30wg2HGEDwyAAz0rwbin9XTQjg@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] str_icontains
To: php internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
From: youkidearitai@gmail.com (youkidearitai)

2025=E5=B9=B46=E6=9C=8824=E6=97=A5(=E7=81=AB) 9:00 Larry Garfield <larry@ga=
rfieldtech.com>:
>
> On Sun, Jun 15, 2025, at 3:12 PM, Adam Cable wrote:
> > Hello internals,
> >
> > I'd like to present my first RFC - str_icontains, a case-insensitive
> > friend of str_contains
> >
> > RFC: https://wiki.php.net/rfc/str_icontains
> > PR (including tests): https://github.com/php/php-src/pull/18705
> >
> > Previous discussion: https://externals.io/message/127504
> >
> > Thanks,
> > Adam
>
> When str_contains() was added, a case-insensitive version was deliberatel=
y omitted in favor of "just use strtolower() yourself."  Have you gone back=
 to see the arguments for that to determine if they're still relevant?
>
> (I don't recall the details; I think one of them was function count explo=
sion, but I think there were more.)
>
> --Larry Garfield

Hi
I have concerns from multibyte(Unicode) user.

As someone who relies on Unicode, I feel that it is not worth using
that function.
str_contains can matches binary, so this is benefit of many reason,
but str_icontains is only support ASCII.
This only benefits some regions.

Regards
Yuya

--=20
---------------------------
Yuya Hamada (tekimen)
- https://tekitoh-memdhoi.info
- https://github.com/youkidearitai
-----------------------------