Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:12774 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 95853 invoked by uid 1010); 13 Sep 2004 18:41:27 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 81069 invoked from network); 13 Sep 2004 18:37:44 -0000 Received: from unknown (HELO mproxy.gmail.com) (216.239.56.251) by pb1.pair.com with SMTP; 13 Sep 2004 18:37:44 -0000 Received: by mproxy.gmail.com with SMTP id w67so50553cwb for ; Mon, 13 Sep 2004 11:37:43 -0700 (PDT) Received: by 10.11.119.62 with SMTP id r62mr112677cwc; Mon, 13 Sep 2004 11:37:43 -0700 (PDT) Received: by 10.11.117.13 with HTTP; Mon, 13 Sep 2004 11:37:43 -0700 (PDT) Message-ID: <4e89b4260409131137443d5ce0@mail.gmail.com> Date: Mon, 13 Sep 2004 19:37:43 +0100 Reply-To: Wez Furlong To: steph@zend.com Cc: internals In-Reply-To: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit References: Subject: Re: [PHP-DEV] [PATCH] ok this works in all cases and smells right From: kingwez@gmail.com (Wez Furlong) On Mon, 13 Sep 2004 18:55:14 +0100, Steph wrote: > BTW shouldn't main/config.w32.h be in .cvsignore? Ideally, yes, but it's still used as-is by the .dsp build system Your patch looks much better (note that the # character for #define's and #ifdefs etc. should start in the left-most column, otherwise some weirdo compilers will break). --Wez.