Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127715
Precedence: bulk
MIME-Version: 1.0
References: <CALaXqqRKy4_y3HkO6dVhVcOjoHOp=HYdsU7v3SVZQ8kr1EfgLA@mail.gmail.com>
 <CAMzRQTfnY3be01kOqXvupFDVHWRt3S53yshk3sV4DmyWYAj9Lw@mail.gmail.com>
In-Reply-To: <CAMzRQTfnY3be01kOqXvupFDVHWRt3S53yshk3sV4DmyWYAj9Lw@mail.gmail.com>
Date: Wed, 18 Jun 2025 23:47:41 +0200
Message-ID: <CAPyj-LCSOJbd-vi72L3n=GxdcSYQNtyHQ-Odg8rOwgBGNYZN_A@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] [Discussion] #[\DelayedTargetValidation] attribute
To: php internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
From: tovilo.ilija@gmail.com (Ilija Tovilo)

Hi Volker

On Wed, Jun 18, 2025 at 2:23=E2=80=AFPM Volker Dusch <volker@tideways-gmbh.=
com> wrote:
>
> On Wed, Jun 18, 2025 at 1:28=E2=80=AFAM Daniel Scherzer <daniel.e.scherze=
r@gmail.com> wrote:
>>
>> I'd like to start the discussion for a new RFC about adding a `#[\Delaye=
dTargetValidation]` attribute.
>>
>> * RFC: https://wiki.php.net/rfc/delayedtargetvalidation_attribute
>> * Implementation: https://github.com/php/php-src/pull/18817
>
>
> While I'm in favor of the RFC, I'd more like to see the default behavior =
of internal and userland attributes adjusted to work the same, with both ha=
ving delayed validation enabled by default. Treating core attributes differ=
ently doesn't make sense to me.
>
> So, if that's someone you're willing to work on, I'd very much prefer tha=
t.

I wouldn't support that, because internal attributes with effects are
not usually instantiated.

class C {
    #[\SensitiveParameter] // This doesn't actually do anything, only
works on parameters
    public $prop;
}

I would get no indication that this attribute doesn't behave as I
expect. We have at least a few attributes with confusable targets
(SensitiveParameter, Override, Deprecated, NoDiscard). User attributes
can't have effects without at least reading them through reflection,
although granted they don't necessarily need to be instantiated, and
so might also not trigger the error.

Ilija