Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127710
Precedence: bulk
MIME-Version: 1.0
References: <CALaXqqRKy4_y3HkO6dVhVcOjoHOp=HYdsU7v3SVZQ8kr1EfgLA@mail.gmail.com>
 <CAMzRQTfnY3be01kOqXvupFDVHWRt3S53yshk3sV4DmyWYAj9Lw@mail.gmail.com>
In-Reply-To: <CAMzRQTfnY3be01kOqXvupFDVHWRt3S53yshk3sV4DmyWYAj9Lw@mail.gmail.com>
Date: Wed, 18 Jun 2025 06:19:13 -0700
Message-ID: <CALaXqqRER-3=UpC9Yz7SGNh0z9uRsUFUqwxkvVB3oGZP=94Vdg@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] [Discussion] #[\DelayedTargetValidation] attribute
To: Volker Dusch <volker@tideways-gmbh.com>
Cc: php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000ad4bea0637d87b22"
From: daniel.e.scherzer@gmail.com (Daniel Scherzer)

--000000000000ad4bea0637d87b22
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 18, 2025 at 5:22=E2=80=AFAM Volker Dusch <volker@tideways-gmbh.=
com>
wrote:

> On Wed, Jun 18, 2025 at 1:28=E2=80=AFAM Daniel Scherzer <
> daniel.e.scherzer@gmail.com> wrote:
>
>> I'd like to start the discussion for a new RFC about adding a
>> `#[\DelayedTargetValidation]` attribute.
>>
>> * RFC: https://wiki.php.net/rfc/delayedtargetvalidation_attribute
>> * Implementation: https://github.com/php/php-src/pull/18817
>>
>
> Hi Daniel,
>
> One note on the example code:
>
> `class Base {`
> `class Child extends Parent {` \
>
> Parent isn't a valid class name, and I think you wanted to extend from
> Base here? I'd prefer the example to compile so that they can be used for
> documentation later on where possible.
>
> Kind Regards,
> Volker
>
>

Fixed, thanks.

--000000000000ad4bea0637d87b22
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Wed, Jun 18, 2025 at 5:22=E2=80=AFAM V=
olker Dusch &lt;<a href=3D"mailto:volker@tideways-gmbh.com">volker@tideways=
-gmbh.com</a>&gt; wrote:</div><div class=3D"gmail_quote gmail_quote_contain=
er"><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bor=
der-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div=
 dir=3D"ltr">On Wed, Jun 18, 2025 at 1:28=E2=80=AFAM Daniel Scherzer &lt;<a=
 href=3D"mailto:daniel.e.scherzer@gmail.com" target=3D"_blank">daniel.e.sch=
erzer@gmail.com</a>&gt; wrote:</div><div class=3D"gmail_quote"><blockquote =
class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px sol=
id rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div>I&#39;d like to=
 start the discussion for a new RFC about adding a `#[\DelayedTargetValidat=
ion]` attribute.</div><div><br></div><div>* RFC:=C2=A0<a href=3D"https://wi=
ki.php.net/rfc/delayedtargetvalidation_attribute" target=3D"_blank">https:/=
/wiki.php.net/rfc/delayedtargetvalidation_attribute</a></div><div>* Impleme=
ntation:=C2=A0<a href=3D"https://github.com/php/php-src/pull/18817" target=
=3D"_blank">https://github.com/php/php-src/pull/18817</a></div></div>
</blockquote></div><div><br clear=3D"all"></div><div>Hi Daniel,</div><div><=
br></div><div>One note on the example code:</div><div><br></div><div>`class=
 Base {`=C2=A0</div><div>`class Child extends Parent {` \</div><div><br></d=
iv><div>Parent isn&#39;t a valid class name, and I think you wanted to exte=
nd from Base here? I&#39;d prefer the example to compile so that they can b=
e used for documentation later on where possible.</div><div><br></div><div>=
Kind Regards,</div><div>Volker</div><div><br></div></div></blockquote><div>=
<br></div><div><br></div><div>Fixed, thanks.=C2=A0</div></div></div>

--000000000000ad4bea0637d87b22--