Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127708
Precedence: bulk
MIME-Version: 1.0
References: <CALaXqqRKy4_y3HkO6dVhVcOjoHOp=HYdsU7v3SVZQ8kr1EfgLA@mail.gmail.com>
In-Reply-To: <CALaXqqRKy4_y3HkO6dVhVcOjoHOp=HYdsU7v3SVZQ8kr1EfgLA@mail.gmail.com>
Date: Wed, 18 Jun 2025 14:22:36 +0200
Message-ID: <CAMzRQTfnY3be01kOqXvupFDVHWRt3S53yshk3sV4DmyWYAj9Lw@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] [Discussion] #[\DelayedTargetValidation] attribute
To: Daniel Scherzer <daniel.e.scherzer@gmail.com>
Cc: php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000efc0d10637d7afd4"
From: volker@tideways-gmbh.com (Volker Dusch)

--000000000000efc0d10637d7afd4
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 18, 2025 at 1:28=E2=80=AFAM Daniel Scherzer <daniel.e.scherzer@=
gmail.com>
wrote:

> I'd like to start the discussion for a new RFC about adding a
> `#[\DelayedTargetValidation]` attribute.
>
> * RFC: https://wiki.php.net/rfc/delayedtargetvalidation_attribute
> * Implementation: https://github.com/php/php-src/pull/18817
>

Hi Daniel,

While I'm in favor of the RFC, I'd more like to see the default behavior of
internal and userland attributes adjusted to work the same, with both
having delayed validation enabled by default. Treating core attributes
differently doesn't make sense to me.

So, if that's someone you're willing to work on, I'd very much prefer that.
But if there are downsides to this approach or if this is too
complicated for other reasons, this attribute is a net positive in my book
to make forward compatibility possible.


One note on the example code:

`class Base {`
`class Child extends Parent {` \

Parent isn't a valid class name, and I think you wanted to extend from Base
here? I'd prefer the example to compile so that they can be used for
documentation later on where possible.

Kind Regards,
Volker

--=20
Volker Dusch
Head of Engineering
Tideways GmbH
K=C3=B6nigswinterer Str. 116
53227 Bonn
https://tideways.io/imprint

Sitz der Gesellschaft: Bonn
Gesch=C3=A4ftsf=C3=BChrer: Benjamin Au=C3=9Fenhofer (geb. Eberlei)
Registergericht: Amtsgericht Bonn, HRB 22127

--000000000000efc0d10637d7afd4
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Wed, Jun 18, 2025 at 1:28=E2=80=AFAM D=
aniel Scherzer &lt;<a href=3D"mailto:daniel.e.scherzer@gmail.com">daniel.e.=
scherzer@gmail.com</a>&gt; wrote:</div><div class=3D"gmail_quote gmail_quot=
e_container"><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px =
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"=
ltr"><div>I&#39;d like to start the discussion for a new RFC about adding a=
 `#[\DelayedTargetValidation]` attribute.</div><div><br></div><div>* RFC:=
=C2=A0<a href=3D"https://wiki.php.net/rfc/delayedtargetvalidation_attribute=
" target=3D"_blank">https://wiki.php.net/rfc/delayedtargetvalidation_attrib=
ute</a></div><div>* Implementation:=C2=A0<a href=3D"https://github.com/php/=
php-src/pull/18817" target=3D"_blank">https://github.com/php/php-src/pull/1=
8817</a></div></div>
</blockquote></div><div><br clear=3D"all"></div><div>Hi Daniel,</div><div><=
br></div><div>While I&#39;m in favor of the RFC, I&#39;d more like to see t=
he default behavior of internal and userland attributes adjusted to work th=
e same, with both having delayed validation enabled by default. Treating co=
re attributes differently doesn&#39;t make sense to me.</div><div><br></div=
><div>So, if that&#39;s someone you&#39;re willing to work on, I&#39;d very=
 much prefer that.</div><div>But if there are downsides to this approach or=
 if this is too complicated=C2=A0for other reasons, this attribute is a net=
 positive in my book to make forward=C2=A0compatibility possible.</div><div=
><br></div><div><br></div><div>One note on the example code:</div><div><br>=
</div><div>`class Base {`=C2=A0</div><div>`class Child extends Parent {` \<=
/div><div><br></div><div>Parent isn&#39;t a valid class name, and I think y=
ou wanted to extend from Base here? I&#39;d prefer the example to compile s=
o that they can be used for documentation later on where possible.</div><di=
v><br></div><div>Kind Regards,</div><div>Volker</div><div><br></div><span c=
lass=3D"gmail_signature_prefix">-- </span><br><div dir=3D"ltr" class=3D"gma=
il_signature"><div dir=3D"ltr"><div style=3D"color:rgb(34,34,34);font-famil=
y:arial,sans-serif;font-size:12.8px">Volker Dusch</div><div style=3D"color:=
rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px">Head of Engine=
ering</div><div style=3D"color:rgb(34,34,34);font-family:arial,sans-serif;f=
ont-size:12.8px"><div>Tideways GmbH</div><div>K=C3=B6nigswinterer Str. 116<=
/div><div>53227 Bonn</div><div><a href=3D"https://tideways.io/imprint" styl=
e=3D"color:rgb(17,85,204)" target=3D"_blank">https://tideways.io/imprint</a=
><br></div><div><br></div><div>Sitz der Gesellschaft: Bonn</div><div>Gesch=
=C3=A4ftsf=C3=BChrer: Benjamin Au=C3=9Fenhofer (geb. Eberlei)</div><div>Reg=
istergericht: Amtsgericht Bonn, HRB 22127</div></div></div></div></div>

--000000000000efc0d10637d7afd4--