Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127704
Content-Type: multipart/alternative; boundary=Apple-Mail-9296EB00-647F-4919-B94A-7AC00B391CBA
Content-Transfer-Encoding: 7bit
Precedence: bulk
Mime-Version: 1.0 (1.0)
Subject: Re: [PHP-DEV] [RFC] [Discussion] #[\DelayedTargetValidation] attribute
Date: Wed, 18 Jun 2025 13:09:26 +0200
Message-ID: <CBAF53A0-5A02-42F4-AAA7-478A22701A6A@beberlei.de>
References: <1a17d11a-eea7-4f8b-b4f9-bd2a3f71b7d6@app.fastmail.com>
Cc: internals@lists.php.net
In-Reply-To: <1a17d11a-eea7-4f8b-b4f9-bd2a3f71b7d6@app.fastmail.com>
To: Rob Landers <rob@bottled.codes>
From: kontakt@beberlei.de


--Apple-Mail-9296EB00-647F-4919-B94A-7AC00B391CBA
Content-Type: text/plain;
	charset=utf-8
Content-Transfer-Encoding: quoted-printable


Von meinem iPhone gesendet

> Am 18.06.2025 um 11:26 schrieb Rob Landers <rob@bottled.codes>:
>=20
> =EF=BB=BF
>>=20
>> On Wed, Jun 18, 2025, at 01:26, Daniel Scherzer wrote:
>> Hi internals,
>>=20
>> I'd like to start the discussion for a new RFC about adding a `#[\Delayed=
TargetValidation]` attribute.
>>=20
>> * RFC: https://wiki.php.net/rfc/delayedtargetvalidation_attribute
>> * Implementation: https://github.com/php/php-src/pull/18817
>>=20
>> --Daniel
>=20
> Interesting. I=E2=80=99d also argue for the inverse more than this, though=
. I=E2=80=99d like for my attributes to be validated during compilation inst=
ead of delayed to runtime -- which, it isn=E2=80=99t actually. Runtime valid=
ation ONLY happens when calling ->newInstance() on ReflectionAttribute, and n=
ever before then. So, only when an attribute is actually read during reflect=
ion is it validated. Further, if you never actually instantiate it ... it is=
 never actually validated (i.e., just looking for the presence of an attribu=
te, not the details).
>=20
> https://3v4l.org/UqQKi


As Daniel=E2=80=99s rfc mentions you need to differentiate between compiler a=
nd userland attributes.=20

The compiler attributes are validated at compile time not dueing newInstance=
.

>=20
> =E2=80=94 Rob

--Apple-Mail-9296EB00-647F-4919-B94A-7AC00B391CBA
Content-Type: text/html;
	charset=utf-8
Content-Transfer-Encoding: quoted-printable

<html><head><meta http-equiv=3D"content-type" content=3D"text/html; charset=3D=
utf-8"></head><body dir=3D"auto"><br id=3D"lineBreakAtBeginningOfSignature">=
<div dir=3D"ltr">Von meinem iPhone gesendet</div><div dir=3D"ltr"><br><block=
quote type=3D"cite">Am 18.06.2025 um 11:26 schrieb Rob Landers &lt;rob@bottl=
ed.codes&gt;:<br><br></blockquote></div><blockquote type=3D"cite"><div dir=3D=
"ltr">=EF=BB=BF<title></title><div>On Wed, Jun 18, 2025, at 01:26, Daniel Sc=
herzer wrote:</div><blockquote type=3D"cite" id=3D"qt" style=3D""><div dir=3D=
"ltr"><div>Hi internals,</div><div><br></div><div>I'd like to start the disc=
ussion for a new RFC about adding a `#[\DelayedTargetValidation]` attribute.=
</div><div><br></div><div>* RFC:&nbsp;<a href=3D"https://wiki.php.net/rfc/de=
layedtargetvalidation_attribute">https://wiki.php.net/rfc/delayedtargetvalid=
ation_attribute</a></div><div>* Implementation:&nbsp;<a href=3D"https://gith=
ub.com/php/php-src/pull/18817">https://github.com/php/php-src/pull/18817</a>=
</div><div><br></div><div>--Daniel</div></div></blockquote><div><br></div><d=
iv>Interesting. I=E2=80=99d also argue for the inverse more than this, thoug=
h. I=E2=80=99d like for my attributes to be validated during compilation ins=
tead of delayed to runtime -- which, it isn=E2=80=99t actually. Runtime vali=
dation ONLY happens when calling -&gt;newInstance() on ReflectionAttribute, a=
nd never before then. So, only when an attribute is actually read during ref=
lection is it validated. Further, if you never actually instantiate it ... i=
t is never actually validated (i.e., just looking for the presence of an att=
ribute, not the details).</div><div><br></div><div><a href=3D"https://3v4l.o=
rg/UqQKi">https://3v4l.org/UqQKi</a></div></div></blockquote><div><br></div>=
<div><br></div>As Daniel=E2=80=99s rfc mentions you need to differentiate be=
tween compiler and userland attributes.&nbsp;<div><br></div><div>The compile=
r attributes are validated at compile time not dueing newInstance.<div><br><=
blockquote type=3D"cite"><div dir=3D"ltr"><div><br></div><div id=3D"sig12122=
9152">=E2=80=94 Rob</div></div></blockquote></div></div></body></html>=

--Apple-Mail-9296EB00-647F-4919-B94A-7AC00B391CBA--