Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127650
Feedback-ID: ifab94697:Fastmail
Precedence: bulk
MIME-Version: 1.0
Date: Wed, 11 Jun 2025 21:01:42 +0200
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
Cc: "Volker Dusch" <volker@tideways-gmbh.com>,
 "php internals" <internals@lists.php.net>
Message-ID: <13a82e3a-9ba9-4b3e-a732-d31aeaab659a@app.fastmail.com>
In-Reply-To: <9745e70a50f08c667a3596829248877a@bastelstu.be>
References: 
 <CAMzRQTcN0VpQ_Ap_3WokH+aXp+EuSs=j=FLAL-43-0XgzgNtjg@mail.gmail.com>
 <8f4bdf65-6237-45c8-92a9-82347dfb85a7@app.fastmail.com>
 <9745e70a50f08c667a3596829248877a@bastelstu.be>
Subject: Re: [PHP-DEV] [VOTE] Clone with v2
Content-Type: multipart/alternative;
 boundary=1c33cae4c34541b9ad2cfd1e9f58fc4b
From: rob@bottled.codes ("Rob Landers")

--1c33cae4c34541b9ad2cfd1e9f58fc4b
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 11, 2025, at 17:34, Tim D=C3=BCsterhus wrote:
> Hi
>=20
> Am 2025-06-08 21:15, schrieb Rob Landers:
> > So, it seems like this can only be used for things that can already =
be=20
> > cloned?
>=20
> Yes. It's an extension of the existing cloning functionality.
>=20
> > Things which are directly trying to block an identical clone, but wo=
uld=20
> > otherwise be fine with a clone that changes the value (e.g. value=20
> > objects) aren=E2=80=99t allowed to use this new feature?
> > To me, that feels like an oversight in the design.
>=20
> Trying to enforce =E2=80=9Csingleton=E2=80=9D objects to be able to `=3D=
=3D=3D` compare them=20
> already requires you to take care of quite a number of things (e.g.=20
> making the constructor private, disallowing serialization, =E2=80=A6) =
and=20
> cloning is no different in that regard.
>=20
> Nevertheless you can make `__clone()` private (which means that clonin=
g=20
> is only allowed from within the class, no Exception necessary) and the=
n:
>=20
>      private function __clone() { }
>=20
>      public function withFoo($foo) {
>          if ($this->foo =3D=3D=3D $foo) {
>              return $this;
>          }
>=20
>          return clone($this, ['foo' =3D> $foo]);
>      }
>=20
> To make sure you are only creating a clone when actually changing=20
> anything.
>=20
> Best regards
> Tim D=C3=BCsterhus
>=20

Thank you, that makes sense.

=E2=80=94 Rob
--1c33cae4c34541b9ad2cfd1e9f58fc4b
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html><html><head><title></title></head><body><div>On Wed, Jun =
11, 2025, at 17:34, Tim D=C3=BCsterhus wrote:</div><blockquote type=3D"c=
ite" id=3D"qt" style=3D""><div>Hi</div><div><br></div><div>Am 2025-06-08=
 21:15, schrieb Rob Landers:</div><div>&gt; So, it seems like this can o=
nly be used for things that can already be&nbsp;</div><div>&gt; cloned?<=
/div><div><br></div><div>Yes. It's an extension of the existing cloning =
functionality.</div><div><br></div><div>&gt; Things which are directly t=
rying to block an identical clone, but would&nbsp;</div><div>&gt; otherw=
ise be fine with a clone that changes the value (e.g. value&nbsp;</div><=
div>&gt; objects) aren=E2=80=99t allowed to use this new feature?</div><=
div>&gt; To me, that feels like an oversight in the design.</div><div><b=
r></div><div>Trying to enforce =E2=80=9Csingleton=E2=80=9D objects to be=
 able to `=3D=3D=3D` compare them&nbsp;</div><div>already requires you t=
o take care of quite a number of things (e.g.&nbsp;</div><div>making the=
 constructor private, disallowing serialization, =E2=80=A6) and&nbsp;</d=
iv><div>cloning is no different in that regard.</div><div><br></div><div=
>Nevertheless you can make `__clone()` private (which means that cloning=
&nbsp;</div><div>is only allowed from within the class, no Exception nec=
essary) and then:</div><div><br></div><div>&nbsp;&nbsp;&nbsp;&nbsp; priv=
ate function __clone() { }</div><div><br></div><div>&nbsp;&nbsp;&nbsp;&n=
bsp; public function withFoo($foo) {</div><div>&nbsp;&nbsp;&nbsp;&nbsp;&=
nbsp;&nbsp;&nbsp;&nbsp; if ($this-&gt;foo =3D=3D=3D $foo) {</div><div>&n=
bsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; r=
eturn $this;</div><div>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; =
}</div><div><br></div><div>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nb=
sp; return clone($this, ['foo' =3D&gt; $foo]);</div><div>&nbsp;&nbsp;&nb=
sp;&nbsp; }</div><div><br></div><div>To make sure you are only creating =
a clone when actually changing&nbsp;</div><div>anything.</div><div><br><=
/div><div>Best regards</div><div>Tim D=C3=BCsterhus</div><div><br></div>=
</blockquote><div><br></div><div>Thank you, that makes sense.</div><div>=
<br></div><div id=3D"sig121229152">=E2=80=94 Rob</div></body></html>
--1c33cae4c34541b9ad2cfd1e9f58fc4b--