Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127647
Precedence: bulk
MIME-Version: 1.0
Date: Wed, 11 Jun 2025 12:20:40 +0200
To: Christian Schneider <cschneid@cschneid.com>
Cc: PHP Internals List <internals@lists.php.net>
Subject: Re: [PHP-DEV] Can we make str_(starts|ends)_with variadic?
In-Reply-To: <F91B3DE1-A926-4E0E-A944-BABF09D8CA35@cschneid.com>
References: <CAK7R4ayN=7YzNzQso7bCsSeVn3dyuHKh_40_e_8vr3nrH_uEVw@mail.gmail.com>
 <F91B3DE1-A926-4E0E-A944-BABF09D8CA35@cschneid.com>
Message-ID: <5c212a47cf3600f425039e76aa3d681a@bastelstu.be>
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

Am 2025-06-11 11:58, schrieb Christian Schneider:
> Am 10.06.2025 um 21:46 schrieb Hans Henrik Bergan <hans@loltek.net>:
>> Can we make  str_(starts|ends)_with variadic?
>> ```
>> if (str_starts_with($url, "http://", "https://")) {
>>    // url
>> }
>> if (str_ends_with($filename, ".pdf", ".doc", ".docx")) {
>>    // document
>> }
>> if(str_ends_with($str, ...$validExtensions){
>>    // valid extension
>> }
>> ```
> 
> […]
> 
> Which leaves me +-0 on this,
> - Chris

I agree that the examples are not particularly well-chosen, because the 
correct implementation for the two examples would be:


     if (\in_array(\pathinfo($filename, PATHINFO_EXTENSION), ['pdf', 
'doc', 'docx'], true)) { }

and

     if (\in_array(\Uri\Rfc3986\Uri::parse($url)?->getScheme(), ['http', 
'https'], true)) { }

and then leaving it up to the code developers / the engien to possibly 
optimize `\in_array()` into `match()` or similar when only a small 
number of values need to be matched.

Best regards
Tim Düsterhus