Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127646
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\))
Subject: Re: [PHP-DEV] Can we make str_(starts|ends)_with variadic?
Date: Wed, 11 Jun 2025 11:58:54 +0200
References: <CAK7R4ayN=7YzNzQso7bCsSeVn3dyuHKh_40_e_8vr3nrH_uEVw@mail.gmail.com>
To: PHP Internals List <internals@lists.php.net>
In-Reply-To: <CAK7R4ayN=7YzNzQso7bCsSeVn3dyuHKh_40_e_8vr3nrH_uEVw@mail.gmail.com>
Message-ID: <F91B3DE1-A926-4E0E-A944-BABF09D8CA35@cschneid.com>
From: cschneid@cschneid.com (Christian Schneider)

Am 10.06.2025 um 21:46 schrieb Hans Henrik Bergan <hans@loltek.net>:
> Can we make  str_(starts|ends)_with variadic?
> ```
> if (str_starts_with($url, "http://", "https://")) {
>    // url
> }
> if (str_ends_with($filename, ".pdf", ".doc", ".docx")) {
>    // document
> }
> if(str_ends_with($str, ...$validExtensions){
>    // valid extension
> }
> ```

Hmm, being old-fashioned I would probably do this with a regex:
str_starts_with($url, "http://", "https://")	=3D>	=
preg_match('#^https?://#', $url)
str_ends_with($filename, ".pdf", ".doc", ".docx")	=3D>	=
preg_match('#\.(pdf|doc|docx)$#', $filename)
str_ends_with($str, ...$validExtensions)	=3D>	=
preg_match('#\.(' . implode('|', array_map(fn($v) =3D> preg_quote($v, =
'#'), $ validExtensions)) . ')$#', $str)

And even though the variadic versions could easily be implemented in =
user-land I see your point about your version being clearer and less =
error-prone, even though my old brain is worried about a hidden loop =
(but that's an implementation detail and can be avoided if one really =
wants to).

Another way of thinking about it would be
array_any($validExtensions, fn($ext) =3D> str_ends_with($str, $ext))
which is quite concise as well and avoids reimplementing iteration for =
individual functions separately.

Which leaves me +-0 on this,
- Chris