Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127631
Precedence: bulk
MIME-Version: 1.0
Date: Mon, 09 Jun 2025 16:53:35 +0200
To: Nick <php@nicksdot.dev>
Cc: internals@lists.php.net
Subject: Re: [PHP-DEV] Allow hooks in `readonly` promoted properties
In-Reply-To: <FC67945A-75FE-4C56-B5F7-05E2735AB2D6@nicksdot.dev>
References: <B0250A18-3C43-4DFD-9D99-3391C23D9D65@nicksdot.dev>
 <f4d0567f-c364-433b-b5b7-60fae49f9046@app.fastmail.com>
 <28F14D0F-8483-418D-85D1-660564A4EAE2@nicksdot.dev>
 <bfec2063-5304-48c1-bc19-203eb62c1237@app.fastmail.com>
 <26AA81AF-1610-494D-A811-10F7B282CBD4@nicksdot.dev>
 <1c0df916e4cfbc746b5dddf935d165a9@bastelstu.be>
 <FC67945A-75FE-4C56-B5F7-05E2735AB2D6@nicksdot.dev>
Message-ID: <3999c537c17adcd06555abda17b9334d@bastelstu.be>
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

Am 2025-06-04 15:39, schrieb Nick:
>> Your test cases really only scratch the surface of what should be 
>> tested. You are basically just verifying that it compiles. In fact you 
>> are not even testing that reassigning the property is disallowed, 
>> because the test fails due to a visibility error. In fact it appears 
>> that the `readonly` check comes before the visibility check, which 
>> would imply that the `readonly` doesn't have an effect: 
>> https://3v4l.org/nqgpL
> 
> https://github.com/php/php-src/pull/18757/files#diff-fdc22521b074231ac6de0df97aeb23a4759ad9b668d3b9ed3fedf8727f5795a4R21
> 
> It checks re-assignment, and expects:
> 
>> Cannot modify protected(set) readonly property Test1::$prop from 
>> global scope
> 
> It’s tested for readonly props, readonly class and promoted properties.
> 
> Correct me, but this is what you are talking about, isn't it? Anything 
> else you are missing?

Your link to GitHub is dead (probably due to the force-pushes), but the 
tests in the current version of the PR resolved my question by 
attempting to re-assign from within the class (such that visibility is 
not the cause of the error).

Best regards
Tim Düsterhus