Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127624
Message-ID: <0E4D7F17-7920-4D5E-8FE1-67699E477786@nicksdot.dev>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_18D44263-8082-4145-8D37-81E2DDE384B6"
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\))
Subject: Re: [PHP-DEV] [RFC] Readonly property hooks
Date: Sun, 8 Jun 2025 20:27:24 +0700
In-Reply-To: <CAMzRQTdDNsF_LPpNKUbVROTWjDbN2uDw-j2PrL3xp7qASA62GA@mail.gmail.com>
Cc: Larry Garfield <larry@garfieldtech.com>,
 php internals <internals@lists.php.net>
To: Volker Dusch <volker@tideways-gmbh.com>
References: <1e8634d7-ac1a-4025-b4e2-1948aabf5251@app.fastmail.com>
 <CAMzRQTdDNsF_LPpNKUbVROTWjDbN2uDw-j2PrL3xp7qASA62GA@mail.gmail.com>
From: php@nicksdot.dev (Nick)


--Apple-Mail=_18D44263-8082-4145-8D37-81E2DDE384B6
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

Hey Volker,

> On 8. Jun 2025, at 19:17, Volker Dusch <volker@tideways-gmbh.com> =
wrote:
>=20
> a) =46rom the "ProductFromDB" i get:
>=20
> > Fatal error: Uncaught TypeError: LazyProduct::$category::get(): =
Return value must be of type Category, none returned in ...
>=20
> I assume you're missing a return statement here? Or is there something =
I'm missing?
>=20
> d) PositivePoint
>=20
> Example doesn't compile against 8.4, master, or against =
NickSdot:readonly-hooks
>=20
> Can you make this a script that runs and shows expected output so that =
readers don't have to assume this is supposed to do or run it?

Unfortunate typos in the RFC text. I can=E2=80=99t yet update the RFC =
text myself, but we will make sure they will be fixed shortly!

Meanwhile, you can find the full running code for both examples here:

=
NickSdot:readonly-hooks/Zend/tests/property_hooks/readonly_rfc_example_laz=
y_product.phpt
=
NickSdot:readonly-hooks/Zend/tests/property_hooks/readonly_rfc_example_val=
idation.phpt

Thanks for pointing these out!

=E2=80=94=20

I leave addressing the other points to Larry.

Cheers,
Nick=

--Apple-Mail=_18D44263-8082-4145-8D37-81E2DDE384B6
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html;
	charset=utf-8

<html><head><meta http-equiv=3D"content-type" content=3D"text/html; =
charset=3Dutf-8"></head><body style=3D"overflow-wrap: break-word; =
-webkit-nbsp-mode: space; line-break: after-white-space;">Hey Volker,<br =
id=3D"lineBreakAtBeginningOfMessage"><div><br><blockquote =
type=3D"cite"><div>On 8. Jun 2025, at 19:17, Volker Dusch =
&lt;volker@tideways-gmbh.com&gt; wrote:</div><div><div =
dir=3D"ltr"><div><br></div><div>a) =46rom the "ProductFromDB" i =
get:</div><div><br></div><div>&gt; Fatal error: Uncaught TypeError: =
LazyProduct::$category::get(): Return value must be of type Category, =
none returned in ...</div><div><br></div><div>I assume you're missing a =
return statement here? Or is there something I'm =
missing?</div></div></div></blockquote><blockquote type=3D"cite"><div =
dir=3D"ltr"><div><br></div><div>d) =
PositivePoint</div><div><br></div><div>Example doesn't compile against =
8.4, master, or =
against&nbsp;NickSdot:readonly-hooks</div><div><br></div><div>Can you =
make this a script that runs and shows expected output so that readers =
don't have to assume this is supposed to do or run =
it?</div></div></blockquote><div><br></div><div>Unfortunate typos in the =
RFC text. I can=E2=80=99t yet update the RFC text myself, but we will =
make sure they will be fixed shortly!</div><br></div><div>Meanwhile, you =
can find the full running code for both examples =
here:</div><div><br></div><div>NickSdot:readonly-hooks/Zend/tests/property=
_hooks/readonly_rfc_example_lazy_product.phpt</div><div>NickSdot:readonly-=
hooks/Zend/tests/property_hooks/readonly_rfc_example_validation.phpt</div>=
<div></div><div><br></div><div>Thanks for pointing these =
out!</div><div><br></div><div>=E2=80=94&nbsp;</div><div><br></div><div>I =
leave addressing the other points to =
Larry.</div><div><br></div><div><b>Cheers,</b></div><div>Nick</div></body>=
</html>=

--Apple-Mail=_18D44263-8082-4145-8D37-81E2DDE384B6--