Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127606
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_EDD0B6C4-5EF4-49D8-8034-D77445600D2D"
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\))
Subject: Re: [PHP-DEV] Allow hooks in `readonly` promoted properties
Date: Thu, 5 Jun 2025 14:12:42 +0800
References: <B0250A18-3C43-4DFD-9D99-3391C23D9D65@nicksdot.dev>
To: internals@lists.php.net
In-Reply-To: <B0250A18-3C43-4DFD-9D99-3391C23D9D65@nicksdot.dev>
Message-ID: <3FBC491A-FE60-4583-A3A2-0A58EC384C88@nicksdot.dev>
From: php@nicksdot.dev (Nick)


--Apple-Mail=_EDD0B6C4-5EF4-49D8-8034-D77445600D2D
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

Hey internals,

> On 4. Jun 2025, at 20:19, Nick <php@nicksdot.dev> wrote:
>> I believe at the moment that RFC text is all there is. :-)  I don't =
know that it's worth opening a discussion without at least a mostly-done =
implementation.  Also, Ilija is rather busy on other tasks at the =
moment, as am I.  (Unless someone else wants to jump in to implement it, =
which would be fine.)
>=20
> People often say =E2=80=9Cyou can just do things=E2=80=9D. So I did, =
and tried to contribute the code for your existing RFC text:
>=20
> https://github.com/php/php-src/pull/18757

Would this be expected to work? Can interface properties be declared =
`readonly`?
interface Cleaned
{
    public readonly string $clean { get; } // has readonly
}

class Something implements Cleaned
{
    public function __construct(
        public readonly string $clean {
            get =3D> trim($this->clean);
        }
    ) {}
}

$u =3D new Something('   Yoda   ');
var_dump($u->clean);
In my current implementation it would throw:

> Fatal error: Hooked virtual properties cannot be readonly in=20

I=E2=80=99d appreciate input here.
Thanks in advance!

Cheers,
Nick




--Apple-Mail=_EDD0B6C4-5EF4-49D8-8034-D77445600D2D
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html;
	charset=utf-8

<html><head><meta http-equiv=3D"content-type" content=3D"text/html; =
charset=3Dutf-8"></head><body style=3D"overflow-wrap: break-word; =
-webkit-nbsp-mode: space; line-break: after-white-space;">Hey =
internals,<div><br></div><div><blockquote type=3D"cite" style=3D"color: =
rgb(0, 0, 0);"><div>On 4. Jun 2025, at 20:19, Nick =
&lt;php@nicksdot.dev&gt; wrote:</div></blockquote><blockquote =
type=3D"cite" style=3D"color: rgb(0, 0, 0);"><div><blockquote =
type=3D"cite">I believe at the moment that RFC text is all there is. :-) =
&nbsp;I don't know that it's worth opening a discussion without at least =
a mostly-done implementation. &nbsp;Also, Ilija is rather busy on other =
tasks at the moment, as am I. &nbsp;(Unless someone else wants to jump =
in to implement it, which would be fine.)<br></blockquote><br>People =
often say =E2=80=9Cyou can just do things=E2=80=9D. So I did, and tried =
to contribute the code for your existing RFC =
text:<br><br>https://github.com/php/php-src/pull/18757</div></blockquote><=
div><br></div><div>Would this be expected to work? Can interface =
properties be declared `readonly`?</div><div><div =
style=3D"background-color: rgb(255, 255, 255);"><pre style=3D"font-family:=
 &quot;JetBrains Mono&quot;, monospace; font-size: 12pt;"><span =
style=3D"color: rgb(215, 58, 73);">interface </span><span style=3D"color: =
rgb(227, 98, 9);">Cleaned<br></span>{<br>    <span style=3D"color: =
rgb(215, 58, 73);">public readonly string </span>$clean { <span =
style=3D"color: rgb(0, 92, 197);">get</span>; } // has =
readonly<br>}<br><br><span style=3D"color: rgb(215, 58, 73);">class =
</span><span style=3D"color: rgb(227, 98, 9);">Something </span><span =
style=3D"color: rgb(215, 58, 73);">implements </span><span style=3D"color:=
 rgb(111, 66, 193);">Cleaned<br></span>{<br>    <span style=3D"color: =
rgb(215, 58, 73);">public function </span><span style=3D"color: rgb(111, =
66, 193);">__construct</span>(<br>        <span style=3D"color: rgb(215, =
58, 73);">public readonly string </span>$clean {<br>            get =
<span style=3D"color: rgb(179, 29, 40);">=3D</span>&gt; <span =
style=3D"color: rgb(0, 92, 197);">trim</span>($this-&gt;<span =
style=3D"color: rgb(0, 92, 197);">clean</span>);<br>        }<br>    ) =
{}<br>}<br><br>$u <span style=3D"color: rgb(179, 29, 40);">=3D =
</span><span style=3D"color: rgb(215, 58, 73);">new </span><span =
style=3D"color: rgb(227, 98, 9); font-size: 12pt;">Something</span><span =
style=3D"font-size: 12pt;">('   Yoda   ');</span><br><span style=3D"color:=
 rgb(111, 66, 193);">var_dump</span>($u<span style=3D"color: rgb(179, =
29, 40);">-&gt;</span>clean);</pre></div><div>In my current =
implementation it would throw:</div><div><br></div><div>&gt;&nbsp;<span =
style=3D"font-family: &quot;JetBrains Mono&quot;, monospace; font-size: =
12pt; background-color: rgb(255, 255, 255);">Fatal error: Hooked virtual =
properties cannot be readonly =
in&nbsp;</span></div><div><br></div><div>I=E2=80=99d appreciate input =
here.</div><div>Thanks in =
advance!</div><div><br></div><div>Cheers,</div><div>Nick</div><div><br></d=
iv><div><br></div><br></div></div></body></html>=

--Apple-Mail=_EDD0B6C4-5EF4-49D8-8034-D77445600D2D--