Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127578
Content-Type: text/plain;
	charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\))
Subject: Re: [PHP-DEV] Allow hooks in `readonly` promoted properties
Date: Wed, 4 Jun 2025 20:19:57 +0800
References: <B0250A18-3C43-4DFD-9D99-3391C23D9D65@nicksdot.dev>
 <f4d0567f-c364-433b-b5b7-60fae49f9046@app.fastmail.com>
 <28F14D0F-8483-418D-85D1-660564A4EAE2@nicksdot.dev>
 <bfec2063-5304-48c1-bc19-203eb62c1237@app.fastmail.com>
To: internals@lists.php.net
In-Reply-To: <bfec2063-5304-48c1-bc19-203eb62c1237@app.fastmail.com>
Message-ID: <26AA81AF-1610-494D-A811-10F7B282CBD4@nicksdot.dev>
From: php@nicksdot.dev (Nick)

Hey all,

> On 4. Jun 2025, at 01:03, Larry Garfield <larry@garfieldtech.com> =
wrote:
>=20
> It's about expectation setting.  If you see a property marked =
`readonly`, it's reasonable to expect this to be true:
>=20
> $foo->bar =3D=3D $foo->bar;
>=20
> For a traditional field (pre-hooks), this would be trivially true.  =
With hooks, it may or may not be.  Saying "well, that assumption doesn't =
hold anymore, deal" is certainly an option, but it's not an option we =
wanted to pursue as part of the larger RFC.  But that is certainly a =
direction we could take.

Larry, I understand now that you in fact explicitly talk about =
random_int().=20
Previously, I did not. I was more on the =E2=80=9Cmanipulating in =
general=E2=80=9D meta level.

Fair. If someone really wants to add random_int(): "well, that =
assumption doesn't hold anymore, deal=E2=80=9D from my side.

>> So, I would love to see this RFC to be implemented.
>> Maybe you want to move it to discussion? Then my separate thread here=20=

>> would be obsolete.
>=20
> I believe at the moment that RFC text is all there is. :-)  I don't =
know that it's worth opening a discussion without at least a mostly-done =
implementation.  Also, Ilija is rather busy on other tasks at the =
moment, as am I.  (Unless someone else wants to jump in to implement it, =
which would be fine.)

People often say =E2=80=9Cyou can just do things=E2=80=9D. So I did, and =
tried to contribute the code for your existing RFC text:

https://github.com/php/php-src/pull/18757

Can it really be such a little change? I=E2=80=99d appreciate feedback =
from people more experienced than I am. Thanks!

Cheers,
Nick