Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127528
Precedence: bulk
MIME-Version: 1.0
References: <CAPZGkuNkpX=drHENWCS-PuHKz0yWcOhZCmv0Y4Qnk5=DqcvakQ@mail.gmail.com>
 <c97acfab-03b7-4e8f-a62d-663150c119d5@daikaras.lt> <CAPZGkuMxxzA6-9LAjq51KxxOgvXNgz_X57zgB2FjokqKnFEfow@mail.gmail.com>
 <78B00771-EAA7-4191-8B34-C6FAA53B6B66@rwec.co.uk>
In-Reply-To: <78B00771-EAA7-4191-8B34-C6FAA53B6B66@rwec.co.uk>
Date: Mon, 2 Jun 2025 16:20:54 +0800
Message-ID: <CAPZGkuNgtE538SFB0+gPUy_3Ne+95DpFcTUyj3x9TDhRKukdSg@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] Add preserve_key_types to array_keys() to prevent
 unintended int conversion
To: "Rowan Tommins [IMSoP]" <imsop.php@rwec.co.uk>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary="00000000000096ee78063692714d"
From: a766650827@gmail.com (=?UTF-8?B?6ams5q2j5by6?=)

--00000000000096ee78063692714d
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Rowan,

Thank you for the clear technical guidance. I agree we've reached a
consensus that implementing a native Map type would be the proper solution
to this long-standing issue.

To move forward, I'd like to clarify a few practical aspects:

1. **RFC Proposal**
   - Should I initiate an RFC draft at this stage?
   - If yes, would you recommend starting with an "idea" thread on
internals@lists.php.net first?

2. **Implementation Resources**
   - Given my limited experience with PHP core development:
     - What would be the minimal viable prototype to demonstrate
feasibility?
     - Are there active contributors you could refer who might be
interested in collaborating?

3. **Interim Steps**
   - Would it help to:
     - Compile real-world use cases from major frameworks?
     - Benchmark existing userland implementations (e.g., DS\Map)?

I'm committed to driving this improvement and willing to coordinate
non-code efforts. Your advice on the most effective next steps would be
invaluable.

Best regards,
[xiaoma]

Rowan Tommins [IMSoP] <imsop.php@rwec.co.uk> =E4=BA=8E2025=E5=B9=B45=E6=9C=
=8829=E6=97=A5=E5=91=A8=E5=9B=9B 00:43=E5=86=99=E9=81=93=EF=BC=9A

>
>
> On 28 May 2025 14:42:01 BST, "=E9=A9=AC=E6=AD=A3=E5=BC=BA" <a766650827@gm=
ail.com> wrote:
>
> >   First, we could add a parameter like preserve_key_types to array
> >   functions such as array_keys()/array_search() to temporarily handle t=
he
> >   implicit conversion issue.
>
>
> This will not help. The keys are changed when they are *written* to the
> array, not when they are read back out. No option to array_keys can tell
> you whether the key 42 was originally set as '42', because that informati=
on
> is not stored anywhere.
>
>
>
> >   Alternatively, we could introduce a new data type "Map"
>
> Yes, I think this was suggested a couple of times on the previous thread.
> It would be a useful feature, but probably not easy to implement
> efficiently and integrate thoroughly into the language.
>
>
> Regards,
> Rowan Tommins
> [IMSoP]
>

--00000000000096ee78063692714d
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Rowan, =C2=A0<br><br>Thank you for the clear technical =
guidance. I agree we&#39;ve reached a consensus that implementing a native =
Map type would be the proper solution to this long-standing issue. =C2=A0<b=
r><br>To move forward, I&#39;d like to clarify a few practical aspects: =C2=
=A0<br><br>1. **RFC Proposal** =C2=A0<br>=C2=A0 =C2=A0- Should I initiate a=
n RFC draft at this stage? =C2=A0<br>=C2=A0 =C2=A0- If yes, would you recom=
mend starting with an &quot;idea&quot; thread on <a href=3D"mailto:internal=
s@lists.php.net">internals@lists.php.net</a> first? =C2=A0<br><br>2. **Impl=
ementation Resources** =C2=A0<br>=C2=A0 =C2=A0- Given my limited experience=
 with PHP core development: =C2=A0<br>=C2=A0 =C2=A0 =C2=A0- What would be t=
he minimal viable prototype to demonstrate feasibility? =C2=A0<br>=C2=A0 =
=C2=A0 =C2=A0- Are there active contributors you could refer who might be i=
nterested in collaborating? =C2=A0<br><br>3. **Interim Steps** =C2=A0<br>=
=C2=A0 =C2=A0- Would it help to: =C2=A0<br>=C2=A0 =C2=A0 =C2=A0- Compile re=
al-world use cases from major frameworks? =C2=A0<br>=C2=A0 =C2=A0 =C2=A0- B=
enchmark existing userland implementations (e.g., DS\Map)? =C2=A0<br><br>I&=
#39;m committed to driving this improvement and willing to coordinate non-c=
ode efforts. Your advice on the most effective next steps would be invaluab=
le. =C2=A0<br><br>Best regards, =C2=A0<br>[xiaoma]=C2=A0</div><br><div clas=
s=3D"gmail_quote gmail_quote_container"><div dir=3D"ltr" class=3D"gmail_att=
r">Rowan Tommins [IMSoP] &lt;<a href=3D"mailto:imsop.php@rwec.co.uk">imsop.=
php@rwec.co.uk</a>&gt; =E4=BA=8E2025=E5=B9=B45=E6=9C=8829=E6=97=A5=E5=91=A8=
=E5=9B=9B 00:43=E5=86=99=E9=81=93=EF=BC=9A<br></div><blockquote class=3D"gm=
ail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,=
204,204);padding-left:1ex"><br>
<br>
On 28 May 2025 14:42:01 BST, &quot;=E9=A9=AC=E6=AD=A3=E5=BC=BA&quot; &lt;<a=
 href=3D"mailto:a766650827@gmail.com" target=3D"_blank">a766650827@gmail.co=
m</a>&gt; wrote:<br>
<br>
&gt;=C2=A0 =C2=A0First, we could add a parameter like preserve_key_types to=
 array<br>
&gt;=C2=A0 =C2=A0functions such as array_keys()/array_search() to temporari=
ly handle the<br>
&gt;=C2=A0 =C2=A0implicit conversion issue.<br>
<br>
<br>
This will not help. The keys are changed when they are *written* to the arr=
ay, not when they are read back out. No option to array_keys can tell you w=
hether the key 42 was originally set as &#39;42&#39;, because that informat=
ion is not stored anywhere.<br>
<br>
<br>
<br>
&gt;=C2=A0 =C2=A0Alternatively, we could introduce a new data type &quot;Ma=
p&quot;<br>
<br>
Yes, I think this was suggested a couple of times on the previous thread. I=
t would be a useful feature, but probably not easy to implement efficiently=
 and integrate thoroughly into the language.<br>
<br>
<br>
Regards,<br>
Rowan Tommins<br>
[IMSoP]<br>
</blockquote></div>

--00000000000096ee78063692714d--