Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:12752
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: multipart/mixed;
	boundary="----_=_NextPart_001_01C49961.6960D030"
Date: Mon, 13 Sep 2004 08:15:13 +0100
Message-ID: <5A9A683C389FE34AB92155BB46D0D20B01C4D4C0@2krlwwex02.royallondon.royallondongroup.com>
Thread-Topic: Win32 sendmail.c doesn't respect DST
Thread-Index: AcSWTCKgORgetcqcThCL9+cKmQQJbQDFCuKg
To: <internals@lists.php.net>
Subject: RE: [PHP-DEV] Win32 sendmail.c doesn't respect DST
From: John.Carter@royal-london.co.uk ("Carter, John")

------_=_NextPart_001_01C49961.6960D030
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Patch attached for this. Can someone validate my thinking, test and =
commit if possible?

Is it too late for 4.3.9?

Cheers,

John.
 <<sendmail.c.diff>>=20
John Carter
john.carter@royal-london.co.uk
Analyst Programmer Integro Team
IT Department
Royal London
(44) 1625 605735

> -----Original Message-----
> From:	Carter, John=20
> Sent:	09 September 2004 10:01
> To:	internals@lists.php.net
> Subject:	[PHP-DEV] Win32 sendmail.c doesn't respect DST
>=20
> Hi,
>=20
> (Long time lurker, first time poster).
>=20
> *Windows only* 4.3.9rc2
>=20
> sendmail.c sets the date header if you don't supply one, unfortunately =
it doesn't respect DST:
>=20
> I'm in the UK in daylight savings time (i.e. GMT+1)
>=20
> So the time is 09:50, i.e. 09:50 GMT +0100 (08:50 GMT)
>=20
> The current mail header code gives 09:50 GMT +0000 which isn't right. =
The fix looks easy, change the code below:
>=20
> 	zoneh /=3D (60 * 60);
> 	zonem =3D (abs(_timezone) / 60) - (zoneh * 60);
> to:
> 	zoneh /=3D (60 * 60);
> 	zonem =3D (abs(_timezone) / 60) - (zoneh * 60);
> 	zoneh +=3D tm->tm_isdst;
>=20
> in the PostHeader function.
>=20
> I'm waiting to be proved wrong in the most embarrassing way possible =
(particularly as the code has been like this for 8 years).
>=20
> Thanks,
>=20
> John.
>=20
> John Carter
> john.carter@royal-london.co.uk
> Analyst Programmer Integro Team
> IT Department
> Royal London
> (44) 1625 605735
>=20
>=20
>=20
> The contents of this e-mail are confidential and for the addressee =
only.
> If you are not the addressee you should not print, copy or distribute
> this e-mail or use it or its contents or copy or publish its contents
> to any other person.  If you have received this e-mail in error please
> notify us and delete it from your system.
>=20
> The Royal London Mutual Insurance Society Limited for life and pension
> products. Registered in England No. 99064. Registered Office:=20
> 55 Gracechurch Street, London, EC3V 0RL. Royal London Asset Management =
Limited
> for investment management services. Registered in England No. 2244297.
> Registered Office: 55 Gracechurch Street, London, EC3V 0UF.
> Royal London Savings Limited for Individual Savings Accounts.
> Registered in England No. 3642633. Registered Office: 55 Gracechurch =
Street,=20
> London, EC3V 0RL. Royal London Unit Trust Managers Limited
> for unit trusts. Registered in England No. 2372439.
> Registered Office: 55 Gracechurch Street, London, EC3V 0UF.
> All these companies are authorised and regulated by the Financial =
Services Authority.
>=20
> --=20
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>=20

------_=_NextPart_001_01C49961.6960D030--