Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127508
Precedence: bulk
MIME-Version: 1.0
References: <CADuktwNsNK3vRyJqBwMDL07cy1GAGVCkBpCxAs5DTzfEqVy86Q@mail.gmail.com>
 <CAGBsUrf4KRhknui9=Ap94WRBVDD7K_LviT6_Otv4RqPKHYHKYg@mail.gmail.com>
In-Reply-To: <CAGBsUrf4KRhknui9=Ap94WRBVDD7K_LviT6_Otv4RqPKHYHKYg@mail.gmail.com>
Date: Fri, 30 May 2025 08:16:54 +0100
Message-ID: <CADuktwOFNBOf=OmOcfgZU=DcU+TgBymdCg0wLcdQHKWVYvqTuQ@mail.gmail.com>
Subject: Re: [PHP-DEV] Adding in a case-insensitive version of str_contains
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary="0000000000008e86f206365533a7"
From: adamcable@gmail.com (Adam Cable)

--0000000000008e86f206365533a7
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, May 29, 2025 at 10:00=E2=80=AFPM Kamil Tekiela <tekiela246@gmail.co=
m> wrote:

> As I understand, it was a conscious decision not to add this function
> when str_contains was created. The reason is that case sensitivity is
> locale-dependent, and for such use cases, mbstring extension is better
> [1] & [2]. Do you think that locale is a concern here, and if not,
> why? Would it be a good idea to add mb_str_icontains instead?
>
> If you're going to propose an RFC for this, it would be a good idea to
> explain what the real life use case for it is. While str_contains is
> very useful for checking the existence of a byte-string within another
> byte-string, a case-sensitive check doesn't seem to have much use.
>
>  [1]: https://stackoverflow.com/a/63121809/1839439
>  [2]:
> https://wiki.php.net/rfc/str_contains#case-insensitivity_and_multibyte_st=
rings


Thanks for this.

In terms of real-life cases, we deal with a lot of datafeeds and
user-contributed content.
We have lots of rules engines that categorise or display data depending on
the content contained (and sometimes these rules change from time to time).
So for example, we have a rule that if the string contains the word
"exclusive" that it's displayed in a certain way.
We can add a rule that says if (str_contains($text, "exclusive"))... and if
want to include the ability for sentences to start with the word
"Exclusive" we currently have to write like this (as we like functions to
be truthy)...  stripos(" ".$text, $exclusive) OR
str_contains(strtolower($text), "exclusive")

I'd just find it useful to have str_icontains/stri_contains available as
the same ASCII-folding variant that we have for other functions.

--0000000000008e86f206365533a7
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Thu, May 29, 2025 at 10:00=E2=80=AFPM =
Kamil Tekiela &lt;<a href=3D"mailto:tekiela246@gmail.com">tekiela246@gmail.=
com</a>&gt; wrote:</div><div class=3D"gmail_quote gmail_quote_container"><b=
lockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-le=
ft:1px solid rgb(204,204,204);padding-left:1ex">As I understand, it was a c=
onscious decision not to add this function<br>
when str_contains was created. The reason is that case sensitivity is<br>
locale-dependent, and for such use cases, mbstring extension is better<br>
[1] &amp; [2]. Do you think that locale is a concern here, and if not,<br>
why? Would it be a good idea to add mb_str_icontains instead?<br>
<br>
If you&#39;re going to propose an RFC for this, it would be a good idea to<=
br>
explain what the real life use case for it is. While str_contains is<br>
very useful for checking the existence of a byte-string within another<br>
byte-string, a case-sensitive check doesn&#39;t seem to have much use.<br>
<br>
=C2=A0[1]: <a href=3D"https://stackoverflow.com/a/63121809/1839439" rel=3D"=
noreferrer" target=3D"_blank">https://stackoverflow.com/a/63121809/1839439<=
/a><br>
=C2=A0[2]: <a href=3D"https://wiki.php.net/rfc/str_contains#case-insensitiv=
ity_and_multibyte_strings" rel=3D"noreferrer" target=3D"_blank">https://wik=
i.php.net/rfc/str_contains#case-insensitivity_and_multibyte_strings</a></bl=
ockquote><div><br></div><div>Thanks for this.=C2=A0</div><div><br></div><di=
v>In terms of real-life cases, we deal with a lot of datafeeds and user-con=
tributed content.</div><div>We have lots of rules engines that categorise o=
r display data depending on the content contained (and sometimes these rule=
s change from time to time).</div><div>So for example, we have a rule that =
if the string contains the word &quot;exclusive&quot; that it&#39;s display=
ed in a certain way.</div><div>We can add a rule that says if (str_contains=
($text, &quot;exclusive&quot;))... and if want to include the ability for s=
entences=C2=A0to start with the word &quot;Exclusive&quot; we currently hav=
e to write like this (as we like functions to be truthy)...=C2=A0 stripos(&=
quot; &quot;.$text, $exclusive) OR str_contains(strtolower($text), &quot;ex=
clusive&quot;)</div><div><br></div><div>I&#39;d just find it useful to have=
 str_icontains/stri_contains available as the same ASCII-folding variant th=
at we have for other functions.</div></div></div>

--0000000000008e86f206365533a7--