Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127486
Content-Type: multipart/signed;
	boundary="Apple-Mail=_E7076060-553A-43A3-BEB2-F28B1D1EA6A4";
	protocol="application/pgp-signature";
	micalg=pgp-sha256
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\))
Subject: Re: [PHP-DEV] #[Deprecated] Attribute
Date: Tue, 27 May 2025 14:04:56 -0500
References: <CAEPJdu=kopidV44A01Sjv_eLq_fkLsjVuzqXx+j9b9gCahn2Vg@mail.gmail.com>
 <CAOWwgpmwdxnwb+NcHcd59ySwbKKB_1C1nYtPeGkmPXa8F3GXPg@mail.gmail.com>
 <CAESVnVpjyhCH1K5sOHzp8qoa7hUAhRqpfN90JS3CooyFpEOZ2Q@mail.gmail.com>
 <B802520B-C807-4CA4-A462-EF3E6FB33FF8@stitcher.io>
 <CAEPJdun8XD08B+819dex4R1zseMiy==rtDLuPEZXsAeqMM6hQA@mail.gmail.com>
To: PHP Internals <internals@lists.php.net>
In-Reply-To: <CAEPJdun8XD08B+819dex4R1zseMiy==rtDLuPEZXsAeqMM6hQA@mail.gmail.com>
Message-ID: <329A033B-585E-45CD-8171-D0CE8334A8B2@php.net>
From: ramsey@php.net (Ben Ramsey)


--Apple-Mail=_E7076060-553A-43A3-BEB2-F28B1D1EA6A4
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

> On Jan 13, 2021, at 06:43, Benjamin Eberlei <kontakt@beberlei.de> =
wrote:
>=20
> On Wed, Jan 13, 2021 at 1:05 PM Brent Roose <brendt@stitcher.io> =
wrote:
>=20
>> Hi Sara
>>=20
>>> On 22 Dec 2020, at 19:54, Sara Golemon <pollita@php.net> wrote:
>>>=20
>>> On Tue, Dec 22, 2020 at 12:35 PM Nicolas Grekas <
>>> nicolas.grekas+php@gmail.com> wrote:
>>>=20
>>>> It would be great to allow adding this attribute on classes. What =
about
>>>> allowing it right now and not bind it to any runtime side-effect? =
That
>>>> would allow static analyzers to do their job. Same for consts and
>>>> properties by the way.
>>>>=20
>>>> Also, it would be very useful to add named parameters to the =
attribute,
>>>> namely: "package" (the name of the package that declares the =
deprecation)
>>>> and "version" (the version of that package that introduced the
>>>> deprecation), next to the message.
>>>>=20
>>>> This is critical info when building reports of deprecations.
>>>>=20
>>>>=20
>>> You could do that now with a polyfill from userspace. If the =
annotation
>>> need not have an effect, then it's just any other userspace =
implementation.
>>=20
>> The difference is that PHP core has the ability to force =
standarization.
>> There's already JetBrains' implementation of #[Deprecated], which =
Psalm and
>> PhpStan also support, but it's not a real standard. Maybe the FIG =
would one
>> day step in to decide these kinds of things, but the reality is that =
many
>> major frameworks don't follow FIG as closely as they used to. I think
>> there's value in adding attributes in the core, with the goal only =
being
>> static analysis. It'll allow for consistency and that's a valuable =
thing.
>>=20
>=20
> I want to keep #[Deprecated] on other elements than functions / =
methods out
> of this RFC, because they require entirely different implementation
> approaches.
>=20
> We identified in the PR already that this should at some point be
> standardized in core, because internal attributes will currently not =
be
> able to support extension through inheritance by userland for
> implementation reasons.
>=20
> My next RFC update will reflect this future scope.


Last night, I identified a need for `#[Deprecated]` on a userland class =
in one of my libraries, but I had to settle on `@deprecated` for the =
widest range of compatibility.

Has there been anymore thought on putting together an implementation for =
this? I=E2=80=99m happy to draft an RFC if someone is able to help with =
the implementation. I don=E2=80=99t understand the complexities around =
the implementation, but is this something that could make it into 8.5, =
provided an RFC vote passes?

Cheers,
Ben


--Apple-Mail=_E7076060-553A-43A3-BEB2-F28B1D1EA6A4
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iHUEAREIAB0WIQToXQMR3fpbrPOmEOewLZeYnIwHGwUCaDYM2AAKCRCwLZeYnIwH
G7QfAP4ndUScvcRzge0rCtaOam5uBLK80kgWMNKkIaOd8wrHBgD/XBd6hhZ0Yh0D
LviZthB6MoPKyhF3WbIDsT/NVqlgEIs=
=irTW
-----END PGP SIGNATURE-----

--Apple-Mail=_E7076060-553A-43A3-BEB2-F28B1D1EA6A4--