Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127484
Precedence: bulk
MIME-Version: 1.0
References: <7bdbd839b20d233e26e7901ae093ce1b@bastelstu.be>
In-Reply-To: <7bdbd839b20d233e26e7901ae093ce1b@bastelstu.be>
Date: Tue, 27 May 2025 12:07:37 -0600
Message-ID: <CAFMT4Np48UUb6B7AF8tJW4FZOGFQ=HOYJ5L9Ys4W7eF8GzE66Q@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] Make OPcache a non-optional part of PHP
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
Cc: php internals <internals@lists.php.net>, Ilija Tovilo <tovilo.ilija@gmail.com>, 
	Arnaud Le Blanc <arnaud.lb@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
From: levim@php.net (Levi Morrison)

On Mon, May 26, 2025 at 4:49=E2=80=AFAM Tim D=C3=BCsterhus <tim@bastelstu.b=
e> wrote:
>
> Please find the RFC including more details at:
> https://wiki.php.net/rfc/make_opcache_required

Quoting from the RFC:

> OPcache being a non-optional part of PHP and always being loaded does not
> mean that OPcache functionality is always active. This RFC specifically
> does not propose the removal of the existing INI settings, such as
> opcache.enable or opcache.enable_cli.

To me, being able to turn off opcache defeats the purpose of putting it int=
o
core. In fact, take this part of the RFC's introduction:

> As an example, OPcache needs to explicitly be compiled and loaded when
> using the PHP =E2=80=9CDocker Official Image=E2=80=9D, making it easy for=
 users to
> accidentally run without OPcache when using Docker. Furthermore OPcache
> being optional and just =E2=80=9Chooking=E2=80=9D into the engine also me=
ans that there are
> two entirely separate code-paths for core PHP functionality (such as
> loading and compiling a PHP script), which can easily result in
> OPcache-specific bugs (such as #17422) that are hard to detect during
> testing.

If opcache can still be disabled, and isn't enabled by default in CLI, then
in practice we still have all of these issues. The engine may not have to
care about "is opcache around?" but it still has to care "is opcache
enabled?" Dropping the first part isn't that helpful if the second part sti=
ll
has to be asked.