Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:12748
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Date: Sun, 12 Sep 2004 17:50:09 +0100
To: internals@lists.php.net
Message-ID: <20040912165009.GA27298@redhat.com>
Mail-Followup-To: internals@lists.php.net
References: <20040827122550.GC29943@redhat.com> <4142FC13.60702@php.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <4142FC13.60702@php.net>
User-Agent: Mutt/1.4.1i
Subject: Re: [PHP-DEV] Re: [PATCH] zend_operators DVAL_TO_LVAL fix
From: jorton@redhat.com (Joe Orton)

On Sat, Sep 11, 2004 at 03:22:27PM +0200, Ard Biesheuvel wrote:
> Joe Orton wrote:
> >GCC on IA64 does wierd things with this macro, though I think there's a
> >GCC bug involved there too.  This fixes the macro to have well-defined
> >behaviour for all values of 'd', and avoids triggering the GCC bug on
> >IA64 to boot (both PHP users on that platform will be happy):
> 
> This probably has to do with the fact that on 64-bit systems, doubles 
> lack the accuracy to distinguish LONG_MAX from LONG_MAX +1. To be on the 
> safe side here, you might want to use >= LONG_MAX instead of > LONG_MAX, 
> or cast the other way around.

It actually was a GCC bug, in fact, one of our GCC developers tracked it
down: http://gcc.gnu.org/ml/gcc-patches/2004-08/msg02654.html

joe