Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127477
Message-ID: <639E0BE3-F1F7-49F3-801F-721C87134063@gmail.com>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_1F459738-89CC-4B57-96C6-5BD44442C156"
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\))
Subject: Re: [PHP-DEV] ext/gd: changing signatures for functions returning
 true
Date: Tue, 27 May 2025 10:00:12 +0200
In-Reply-To: <CA+XhMqwywRcwgVSwSSHLVEpkLYjOSZWoDGW2v3FTLB72xDdWmw@mail.gmail.com>
Cc: PHP internals <internals@lists.php.net>
To: David CARLIER <devnexen@gmail.com>
References: <CA+XhMqwywRcwgVSwSSHLVEpkLYjOSZWoDGW2v3FTLB72xDdWmw@mail.gmail.com>
From: claude.pache@gmail.com (Claude Pache)


--Apple-Mail=_1F459738-89CC-4B57-96C6-5BD44442C156
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8


> Le 27 mai 2025 =C3=A0 00:51, David CARLIER <devnexen@gmail.com> a =
=C3=A9crit :
>=20
> Hi,
>=20
> Working through this https://github.com/php/php-src/pull/18651/files, =
do not mind waiting for PHP 9 if needs be. Let me know what you think.
>=20
> Cheers.


Hi,

Those functions are documented to return false on failure (e.g. =
https://www.php.net/manual/en/function.imagesetthickness.php). For that =
reason, I typically check for failure (e.g., `if (! =
imagesetthickness(...)) { return false; }`).

If some or all functions of the gd library do not or no longer return =
false, please amend the documentation, so that I (and everyone else, see =
e.g. https://phpstan.org/r/a69b0ad4-b4bd-4487-a6d1-a436ce142dc2 ) know =
that those checks are useless without needing to read the php source =
code.

But don=E2=80=99t just change the return type from `bool` to `void`: you =
are needlessly breaking existing code. Thanks!

=E2=80=94Claude=

--Apple-Mail=_1F459738-89CC-4B57-96C6-5BD44442C156
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html;
	charset=utf-8

<html><head><meta http-equiv=3D"content-type" content=3D"text/html; =
charset=3Dutf-8"></head><body style=3D"overflow-wrap: break-word; =
-webkit-nbsp-mode: space; line-break: =
after-white-space;"><br><div><blockquote type=3D"cite"><div>Le 27 mai =
2025 =C3=A0 00:51, David CARLIER &lt;devnexen@gmail.com&gt; a =C3=A9crit =
:</div><br class=3D"Apple-interchange-newline"><div><div =
dir=3D"ltr">Hi,<div><br></div><div>Working through this&nbsp;<a =
href=3D"https://github.com/php/php-src/pull/18651/files">https://github.co=
m/php/php-src/pull/18651/files</a>, do not mind waiting for PHP 9 if =
needs be. Let me know what you =
think.</div><div><br></div><div>Cheers.</div></div>
=
</div></blockquote></div><br><div><br></div><div>Hi,</div><div><br></div><=
div>Those functions are documented to return false on failure =
(e.g.&nbsp;<a =
href=3D"https://www.php.net/manual/en/function.imagesetthickness.php">http=
s://www.php.net/manual/en/function.imagesetthickness.php</a>). For that =
reason, I typically check for failure (e.g., `if (! =
imagesetthickness(...)) { return false; }`).</div><div><br></div><div>If =
some or all functions of the gd library do not or no longer return =
false, please amend the documentation, so that I (and everyone else, see =
e.g.&nbsp;<a =
href=3D"https://phpstan.org/r/a69b0ad4-b4bd-4487-a6d1-a436ce142dc2">https:=
//phpstan.org/r/a69b0ad4-b4bd-4487-a6d1-a436ce142dc2</a>&nbsp;) know =
that those checks are useless without needing to read the php source =
code.</div><div><br></div><div>But don=E2=80=99t just change the return =
type from `bool` to `void`: you are needlessly breaking existing code. =
Thanks!</div><div><br></div><div>=E2=80=94Claude</div></body></html>=

--Apple-Mail=_1F459738-89CC-4B57-96C6-5BD44442C156--