Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127475
To: internals@lists.php.net
Subject: Re: [PHP-DEV] [RFC] Add num_available_processors
Date: Tue, 27 May 2025 09:38:22 +0200
Message-ID: <6208340.lOV4Wx5bFT@come-prox15amd>
In-Reply-To: <8b76a3d4-4583-4849-a75f-00f645191247@gmail.com>
References:
 <bc1ec15125844c78a6aa23dce6148af9@danielkesselberg.de>
 <8b76a3d4-4583-4849-a75f-00f645191247@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart5061789.31r3eYUQgx";
 micalg="pgp-sha512"; protocol="application/pgp-signature"
From: come@chilliet.eu (=?UTF-8?B?Q8O0bWU=?= Chilliet)

--nextPart5061789.31r3eYUQgx
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"; protected-headers="v1"
From: =?UTF-8?B?Q8O0bWU=?= Chilliet <come@chilliet.eu>
To: internals@lists.php.net
Subject: Re: [PHP-DEV] [RFC] Add num_available_processors
Date: Tue, 27 May 2025 09:38:22 +0200
Message-ID: <6208340.lOV4Wx5bFT@come-prox15amd>
In-Reply-To: <8b76a3d4-4583-4849-a75f-00f645191247@gmail.com>
MIME-Version: 1.0

Le samedi 24 mai 2025, 19:42:34 heure d=E2=80=99=C3=A9t=C3=A9 d=E2=80=99Eur=
ope centrale Niels Dossche a =C3=A9crit :
> In my opinion, the return type should not be nullable.
> Returning NULL when the platform (or PHP on that platform) doesn't suppor=
t getting this information is an anti-pattern.
> Instead, availability of the necessary functionality should be checked at=
 configure time and the function should be made conditionally available.
> That way, the return type can just be "int".

I strongly disagree here, having PHP function not always available is a mes=
s, and forces function_exists checks all over the code. It feels archaic.

I get the idea of throwing instead of returning NULL for errors, but the id=
ea behind the nullable return is to get this nice thing:
$cpus =3D num_available_cpus() ?? 1;

If the function throws on error, this gets more convoluted. Maybe it can be=
 replaced by a parameter $defaultNumber and only throw when no default is g=
iven?

Regarding the CPUs available for PHP or total number discussion, maybe that=
 justifies the "available" keyword in the name and it returns only those av=
ailable to PHP, and we add a second function for total number?
Or as some people suggested in the PR, we add a namespaced class with metho=
ds for this.

C=C3=B4me
--nextPart5061789.31r3eYUQgx
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEE8x20ac73tsA2u7cuwRZWc8b9+7kFAmg1a+8ACgkQwRZWc8b9
+7kl4Af+PHpx1Ts1agWg6RwNB2p76Zs0ir4wUg/psgGbHwwFK93MOSRrZOM3b3co
KhYFJ9f2NmnQgf48PE8JYz7PpAPj4KHgTdH/jY97GaYbmmKjgtz7Tw6OvKHznuVW
PXGMixTYjytqY2+cJCYV5K/iIOQHSErBYiT/QXn0bQ+/l3C0/b3XlwgdKXMJRTUE
VMlOi4w9+MrUfwd2yJSY1mqdofBNUbWsKSVMIUTW7mxb69615CTvpJ5K0D6xloj6
VFSQ/FdtKX+J9VjF53GwrFnw1nTyu9rqAxvy5Lr/lFk5eoe/UndkCk4DoyUw2K/5
Iw/QqOqeqr8ZuFLTzslTSYEEmVfyoQ==
=6cS+
-----END PGP SIGNATURE-----

--nextPart5061789.31r3eYUQgx--