Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127454
Precedence: bulk
MIME-Version: 1.0
Date: Sun, 25 May 2025 16:17:53 +0200
To: Alwin Garside <alwin@garsi.de>
Cc: Daniel Kesselberg <mail@danielkesselberg.de>, Rob Landers
 <rob@bottled.codes>, PHP Internals <internals@lists.php.net>
Subject: Re: [PHP-DEV] [RFC] Add num_available_processors
In-Reply-To: <60B4033B-2E6A-4157-A698-6C58454B07C9@garsi.de>
References: <bc1ec15125844c78a6aa23dce6148af9@danielkesselberg.de>
 <a1509633-ad50-4779-bc46-0f782cd8b7c5@app.fastmail.com>
 <60B4033B-2E6A-4157-A698-6C58454B07C9@garsi.de>
Message-ID: <4862b0d32cb4f9408f2cea55c6677345@bastelstu.be>
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

Am 2025-05-25 12:07, schrieb Alwin Garside:
> Finally, from a quick search in php-src there doesn't seem to be any 
> existing function name that starts with `num_`. For the sake of 
> consistency with the existing PHP functions, and similar functionality 
> in other languages, I suggest suffixing the function name with `_count` 
> instead.
> 
> So, to wrap this all up, I'd like to respectfully propose the following 
> function name instead:
> 
>     cpu_core_count()

Naming is a good point indeed and one that I also hinted at with my 
comment on the PR: 
https://github.com/php/php-src/pull/11137#issuecomment-2888977523

I very strongly disagree with adding more “randomly named” functions to 
ext/standard, the times of doing that are over. I would also claim that 
it violates the “Coding Standards and Naming Policy” 
(https://github.com/php/policies/blob/main/coding-standards-and-naming.rst) 
in spirit.

At the very least the function should have a clear “prefix”. `sys` as in 
`sys_getloadavg()` or `sys_get_temp_dir()` would probably work. 
Alternatively `get` as in `getmyuid()` or `getrusage()` would also work.

As I've indicated in the PR, my preference would be creating a new 
namespace and moving over the matching functions together with a 
discussion of some namespace structure, including matching exceptions 
(see https://wiki.php.net/rfc/extension_exceptions).

Best regards
Tim Düsterhus