Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127439
Feedback-ID: id5114917:Fastmail
Date: Sat, 24 May 2025 10:34:24 +0100
To: internals@lists.php.net
Subject: Re: [PHP-DEV] Module or Class Visibility, Season 2
User-Agent: K-9 Mail for Android
In-Reply-To: <CAEUnE0dffEmFHV872btX5x_mbwmRmY1GCw+OPPrtr6sLD+u_zg@mail.gmail.com>
References: <CADK1yXKg1xpneLs3vJ=nUAAGaVuBhqkEMgbBVaYfcBfQL2vkDg@mail.gmail.com> <3ae9a6ea-f135-472b-b2bf-e6cd6ebad299@app.fastmail.com> <CAEUnE0d8QADSYv+OJMEceN4hdJNcNy=-GLvW-ZoNqoi6_2Lhxw@mail.gmail.com> <9A26F72B-D0EF-414F-B193-BED3CAB26A0B@rwec.co.uk> <9f6a0d6e-27c3-4f77-aed6-e55147442b6f@app.fastmail.com> <B46C391D-2248-4E54-BFBE-2195FFB6A2A5@rwec.co.uk> <ca5c49c9-948a-48f0-8b94-86fea583fbc4@app.fastmail.com> <673fd2db-b07f-439b-a4f2-e9519108d159@app.fastmail.com> <CAEUnE0dxRwjhKC64XHWkF3bNRLgjkgSJ9oMajRPfwLoDWy3x-g@mail.gmail.com> <78641D8B-AF1D-4912-920A-D75A37C32F05@rwec.co.uk> <CAEUnE0dVyQ9NQonEBU6wkKM+WsyLXt68jAGYjsz270w_Fa8=Fw@mail.gmail.com> <CF275E74-F6AE-4357-8586-2FF17DC84FB5@rwec.co.uk> <CAEUnE0eR-0c=pDxgFrB4n60rGescZDVzOgb4uJbYK1aLvQE8=A@mail.gmail.com> <354cb888-97c4-4f8c-a0da-359d1e63c0f9@rwec.co.uk> <CAEUnE0dffEmFHV872btX5x_mbwmRmY1GCw+OPPrtr6sLD+u_zg@mail.gmail.com>
Message-ID: <10D95B6E-094B-4EAE-A18A-AF6B795CB352@rwec.co.uk>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: imsop.php@rwec.co.uk ("Rowan Tommins [IMSoP]")



Hi Michael,

I'm going to skip over all the details about the autoloader for now, becau=
se I think they're going deep into implementation details, and I want to fo=
cus on the same top-level design as my previous email=2E


On 23 May 2025 02:27:41 BST, Michael Morris <tendoaki@gmail=2Ecom> wrote:
>Bobs docs needs an older version of Monolog and is configured appropriate=
ly
>in its composer=2Ejson file, so =2E=2E=2E v1 is prefixed to the
>namespace declarations in Monolog\Logger and the file is included=2E The
>engine aliases BobsDocs\Monolog\Logger to \v1\Monolog\Logger=2E


If I'm following correctly, you suggest that we would end up with class na=
mes like this:

\v1\Monolog\Logger
\v2\Monolog\Logger
\v5\Google\Client
\v7\Google\Client

It feels like there's a lot of complexity in the package manager here - it=
's got to keep track of which versions of each package are installed, what =
they depend on, and decide what prefixes need to be used where=2E You also =
suggest that one version of each package is left with no prefix, which adds=
 even more complexity=2E


>The Googl\ApiClient of BobDocs is again, up to the autoloader=2E Assuming=
 it
>too is different (since it's using an older Monolog)

The biggest problem comes when this assumption doesn't hold=2E I actually =
chose these particular packages to illustrate this problem, then left it ou=
t of my previous message=2E It happens that the latest version of google/ap=
iclient supports both monolog/monolog 2=2E9 and 3=2E0, so it's possible to =
have:=20

- AlicesCalendar wants to use google/apiclient 2=2E18 and monolog/monolog =
2=2E9
- BobsDocs wants to use google/apiclient 2=2E18 and monolog/monolog 3=2E0

If the package manager is adding prefixes to individual package versions, =
we will have one class called \v2_18\Google\Client containing our familiar =
"new Logger" line=2E AlicesCalendar will expect that line to create a \v2_9=
\Monolog\Logger, but BobsDocs will expect it to create a \v3_0\Monolog\Logg=
er=2E We can't please both of them without creating an extra copy of Google=
\Client with a different prefix=2E

So the version of an individual package isn't enough to decide the prefix,=
 we need to know which *set* of packages it belongs to=2E=20


My suggestion uses a much simpler rule to define the prefix: if it's loade=
d "inside" AlicesCalendar, add the prefix "\AlicesCalendar\"=2E All the cla=
sses that are "inside" are completely sandboxed from the classes "outside",=
 without needing any interaction with a package manager=2E

As far as I know, this is how existing userland solutions work, and I have=
n't yet spotted a reason why it needs to be any more complex than that=2E


Regards,
Rowan Tommins
[IMSoP]