Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127394
Precedence: bulk
MIME-Version: 1.0
References: <CAMzRQTdePFXUMWO38g=gQA2vbqL5zp=o1cPt00ec41g95xys=g@mail.gmail.com>
 <CAJp_myXREmnyufwxj4tDCsopouUFEWenap5EJaH+sXKTyg4K1Q@mail.gmail.com>
 <4a703db4174763586d84b9bf5606ff31@bastelstu.be> <b1bef725-5c17-47c4-8019-7f3135a5a682@app.fastmail.com>
 <956887e5b66e2b43459b999ebac2069d@bastelstu.be> <CAOWwgpkv-5BgLKM9xp9nmGRMu6u2yteQ4KO+6cOYKsF1ivtZ3w@mail.gmail.com>
In-Reply-To: <CAOWwgpkv-5BgLKM9xp9nmGRMu6u2yteQ4KO+6cOYKsF1ivtZ3w@mail.gmail.com>
Date: Sun, 18 May 2025 01:22:15 +0200
Message-ID: <CAMzRQTfbJ4xsfUY6hyLy8vaWn+Zm8etVT7NaKdELa=DNdws+hA@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] Clone with v2
To: Nicolas Grekas <nicolas.grekas+php@gmail.com>
Cc: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>, 
	Larry Garfield <larry@garfieldtech.com>, php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000005835706355d2c6a"
From: volker@tideways-gmbh.com (Volker Dusch)

--00000000000005835706355d2c6a
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, May 16, 2025 at 9:41=E2=80=AFPM Nicolas Grekas <nicolas.grekas+php@=
gmail.com>
wrote:

Being able to update a readonly property even if __clone already touched it
> looks critical to me because otherwise, it'd mean that adding a __clone
> method after publishing a first version of some class that has no __clone
> method would be a BC break.
>

Great input. Thank you Nicolas.

While this only applies to `public public(set) readonly` protected readonly
properties that are also then *touched* in the new clone method, it is
indeed an E_FATAL with the current implementation.

For these cases, that would indeed be an annoying gotcha, even if I don't
have an example at hand, it might make sense to me to account for it. I'll
update the RFC and publish a changelog on Monday, and I'll mention that
there once I had another look at the implementation.


--=20
Volker Dusch
Head of Engineering
Tideways GmbH
K=C3=B6nigswinterer Str. 116
53227 Bonn
https://tideways.io/imprint

Sitz der Gesellschaft: Bonn
Gesch=C3=A4ftsf=C3=BChrer: Benjamin Au=C3=9Fenhofer (geb. Eberlei)
Registergericht: Amtsgericht Bonn, HRB 22127

--00000000000005835706355d2c6a
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><div class=3D"gmail_quote gmail=
_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Fri, May 16, 202=
5 at 9:41=E2=80=AFPM Nicolas Grekas &lt;<a href=3D"mailto:nicolas.grekas%2B=
php@gmail.com">nicolas.grekas+php@gmail.com</a>&gt; wrote:</div><div dir=3D=
"ltr" class=3D"gmail_attr"><br></div><blockquote class=3D"gmail_quote" styl=
e=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);paddin=
g-left:1ex"><div dir=3D"ltr"><div class=3D"gmail_quote"><div>Being able to =
update a readonly property even if __clone already touched it looks critica=
l to me because otherwise, it&#39;d mean that adding a __clone method after=
 publishing a first version of some class that has no __clone method would =
be a BC break.</div></div></div></blockquote><div><br></div><div>Great inpu=
t. Thank you Nicolas.</div><div><br></div><div>While this only applies to `=
public public(set) readonly` protected readonly properties that are also th=
en *touched* in the new clone method, it is indeed an E_FATAL with the curr=
ent implementation.</div><div><br></div><div>For these cases, that would in=
deed be an annoying gotcha, even if I don&#39;t have an example at hand, it=
 might make sense to me to account for it. I&#39;ll update the RFC and publ=
ish a changelog on Monday, and I&#39;ll mention that there once I had anoth=
er look at the implementation.</div></div><div><br clear=3D"all"></div><div=
><br></div><span class=3D"gmail_signature_prefix">-- </span><br><div dir=3D=
"ltr" class=3D"gmail_signature"><div dir=3D"ltr"><div style=3D"color:rgb(34=
,34,34);font-family:arial,sans-serif;font-size:12.8px">Volker Dusch</div><d=
iv style=3D"color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8=
px">Head of Engineering</div><div style=3D"color:rgb(34,34,34);font-family:=
arial,sans-serif;font-size:12.8px"><div>Tideways GmbH</div><div>K=C3=B6nigs=
winterer Str. 116</div><div>53227 Bonn</div><div><a href=3D"https://tideway=
s.io/imprint" style=3D"color:rgb(17,85,204)" target=3D"_blank">https://tide=
ways.io/imprint</a><br></div><div><br></div><div>Sitz der Gesellschaft: Bon=
n</div><div>Gesch=C3=A4ftsf=C3=BChrer: Benjamin Au=C3=9Fenhofer (geb. Eberl=
ei)</div><div>Registergericht: Amtsgericht Bonn, HRB 22127</div></div></div=
></div></div>

--00000000000005835706355d2c6a--