Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127387
Content-Type: multipart/alternative; boundary=Apple-Mail-03A9F318-89B9-4469-8E47-7D2EA7DAE22E
Content-Transfer-Encoding: 7bit
Precedence: bulk
Mime-Version: 1.0 (1.0)
Subject: Re: [PHP-DEV] [RFC] Clone with v2
Date: Fri, 16 May 2025 12:40:01 +0400
Message-ID: <AA1FAEDD-2890-4C30-A024-9A6AE9DF3B70@gmail.com>
References: <CAMzRQTc1AVYVYe9xDS++DbRbQACF4SLNKU8Q2=teRd4fwy_GCQ@mail.gmail.com>
Cc: Larry Garfield <larry@garfieldtech.com>,
 php internals <internals@lists.php.net>
In-Reply-To: <CAMzRQTc1AVYVYe9xDS++DbRbQACF4SLNKU8Q2=teRd4fwy_GCQ@mail.gmail.com>
To: Volker Dusch <volker@tideways-gmbh.com>
From: xepozzd@gmail.com (Dmitry Derepko)


--Apple-Mail-03A9F318-89B9-4469-8E47-7D2EA7DAE22E
Content-Type: text/html;
	charset=utf-8
Content-Transfer-Encoding: quoted-printable

<html><head><meta http-equiv=3D"content-type" content=3D"text/html; charset=3D=
utf-8"></head><body dir=3D"auto"><div>I really like a way with arrays.&nbsp;=
</div><div>It allows users to combine what properties they want to re-set an=
d call the clone function only once. Really good catch.&nbsp;</div><div><br>=
</div><div><br></div><br id=3D"lineBreakAtBeginningOfSignature"><div dir=3D"=
ltr"><blockquote type=3D"cite"><br>On May 15, 2025, at 9:09=E2=80=AFPM, Volk=
er Dusch &lt;volker@tideways-gmbh.com&gt; wrote:<br><br></blockquote></div><=
blockquote type=3D"cite"><div dir=3D"ltr">=EF=BB=BF<div dir=3D"ltr"><div dir=
=3D"ltr">On Thu, May 15, 2025 at 12:10=E2=80=AFAM Larry Garfield &lt;<a href=
=3D"mailto:larry@garfieldtech.com">larry@garfieldtech.com</a>&gt; wrote:</di=
v><div dir=3D"ltr">&gt; Please include this in the RFC.</div><div dir=3D"ltr=
"><br></div><div dir=3D"ltr">Done</div><div dir=3D"ltr"><br></div><div dir=3D=
"ltr">&gt; The concern is someone calling clone($foo, object: new Thingie())=
, which would complain that "object" is defined twice.&nbsp; Making the firs=
t argument named __object sidesteps that issue</div><div class=3D"gmail_quot=
e gmail_quote_container"><div>&gt; If someone then calls clone(prop: 'new va=
l', __object: $foo), that... I suppose would technically compile, but one sh=
ould never do that, and I am perfectly happy if that breaks.&nbsp; Similar f=
or if someone called clone(prop: 'new val', object: $foo) if we didn't renam=
e that parameter.&nbsp; No one should be doing that and I am fine if that br=
eaks</div><div><br></div><div>Yes. I think we're on the same page here. But j=
ust to be clear, I'll restate it again with my own words:</div><div><br></di=
v><div>Whatever the first parameter (the to-be-cloned object) of the clone()=
 function is called will be completely inaccessible as a property name.&nbsp=
;</div><div><br></div><div>clone($foo, __object: "bar") will fail (Named par=
ameter overwrites previous argument)</div><div>clone($foo, ...["__object" =3D=
&gt; "bar"]) will also fail.&nbsp;</div><div><br></div><div>While `clone(pro=
p: 'new val', __object: $foo)` just works.</div><div><br></div><div>For exam=
ple, using the current implementation where the parameter is named `object`:=
</div><div>```</div><div>class Foo {<br>&nbsp; &nbsp; public int $bar;<br>}<=
br>$x =3D new Foo();<br>var_dump(clone(bar: 5, object: $x));</div></div><div=
><br></div><div>// object(Foo)#2 (1) {<br>//&nbsp; &nbsp;["bar"]=3D&gt;<br>/=
/&nbsp; &nbsp;int(5)<br>// }</div><div>```</div><div><br></div><span class=3D=
"gmail_signature_prefix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signa=
ture"><div dir=3D"ltr"><div style=3D"color:rgb(34,34,34);font-family:arial,s=
ans-serif;font-size:12.8px">Volker Dusch</div><div style=3D"color:rgb(34,34,=
34);font-family:arial,sans-serif;font-size:12.8px">Head of Engineering</div>=
<div style=3D"color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.=
8px"><div>Tideways GmbH</div><div>K=C3=B6nigswinterer Str. 116</div><div>532=
27 Bonn</div><div><a href=3D"https://tideways.io/imprint" style=3D"color:rgb=
(17,85,204)" target=3D"_blank">https://tideways.io/imprint</a><br></div><div=
><br></div><div>Sitz der Gesellschaft: Bonn</div><div>Gesch=C3=A4ftsf=C3=BCh=
rer: Benjamin Au=C3=9Fenhofer (geb. Eberlei)</div><div>Registergericht: Amts=
gericht Bonn, HRB 22127</div></div></div></div></div>
</div></blockquote></body></html>=

--Apple-Mail-03A9F318-89B9-4469-8E47-7D2EA7DAE22E--