Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127383
Precedence: bulk
MIME-Version: 1.0
References: <CAMzRQTdePFXUMWO38g=gQA2vbqL5zp=o1cPt00ec41g95xys=g@mail.gmail.com>
 <533ea02a-dd69-4de9-8526-f808c5a9f4a1@app.fastmail.com> <CAMzRQTc=H24YuFf1Sk2icmfNJp03zyz-+qp8Y88=NFPzNDrjkQ@mail.gmail.com>
 <c2b3ba5e-0315-4484-a768-a597dacab641@app.fastmail.com>
In-Reply-To: <c2b3ba5e-0315-4484-a768-a597dacab641@app.fastmail.com>
Date: Thu, 15 May 2025 19:07:26 +0200
Message-ID: <CAMzRQTc1AVYVYe9xDS++DbRbQACF4SLNKU8Q2=teRd4fwy_GCQ@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] Clone with v2
To: Larry Garfield <larry@garfieldtech.com>
Cc: php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000f4089d06352fb3dd"
From: volker@tideways-gmbh.com (Volker Dusch)

--000000000000f4089d06352fb3dd
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, May 15, 2025 at 12:10=E2=80=AFAM Larry Garfield <larry@garfieldtech=
.com>
wrote:
> Please include this in the RFC.

Done

> The concern is someone calling clone($foo, object: new Thingie()), which
would complain that "object" is defined twice.  Making the first argument
named __object sidesteps that issue
> If someone then calls clone(prop: 'new val', __object: $foo), that... I
suppose would technically compile, but one should never do that, and I am
perfectly happy if that breaks.  Similar for if someone called clone(prop:
'new val', object: $foo) if we didn't rename that parameter.  No one should
be doing that and I am fine if that breaks

Yes. I think we're on the same page here. But just to be clear, I'll
restate it again with my own words:

Whatever the first parameter (the to-be-cloned object) of the clone()
function is called will be completely inaccessible as a property name.

clone($foo, __object: "bar") will fail (Named parameter overwrites previous
argument)
clone($foo, ...["__object" =3D> "bar"]) will also fail.

While `clone(prop: 'new val', __object: $foo)` just works.

For example, using the current implementation where the parameter is named
`object`:
```
class Foo {
    public int $bar;
}
$x =3D new Foo();
var_dump(clone(bar: 5, object: $x));

// object(Foo)#2 (1) {
//   ["bar"]=3D>
//   int(5)
// }
```

--=20
Volker Dusch
Head of Engineering
Tideways GmbH
K=C3=B6nigswinterer Str. 116
53227 Bonn
https://tideways.io/imprint

Sitz der Gesellschaft: Bonn
Gesch=C3=A4ftsf=C3=BChrer: Benjamin Au=C3=9Fenhofer (geb. Eberlei)
Registergericht: Amtsgericht Bonn, HRB 22127

--000000000000f4089d06352fb3dd
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Thu, May 15, 2025 at 12:10=E2=80=AFAM =
Larry Garfield &lt;<a href=3D"mailto:larry@garfieldtech.com">larry@garfield=
tech.com</a>&gt; wrote:</div><div dir=3D"ltr">&gt; Please include this in t=
he RFC.</div><div dir=3D"ltr"><br></div><div dir=3D"ltr">Done</div><div dir=
=3D"ltr"><br></div><div dir=3D"ltr">&gt; The concern is someone calling clo=
ne($foo, object: new Thingie()), which would complain that &quot;object&quo=
t; is defined twice.=C2=A0 Making the first argument named __object sideste=
ps that issue</div><div class=3D"gmail_quote gmail_quote_container"><div>&g=
t; If someone then calls clone(prop: &#39;new val&#39;, __object: $foo), th=
at... I suppose would technically compile, but one should never do that, an=
d I am perfectly happy if that breaks.=C2=A0 Similar for if someone called =
clone(prop: &#39;new val&#39;, object: $foo) if we didn&#39;t rename that p=
arameter.=C2=A0 No one should be doing that and I am fine if that breaks</d=
iv><div><br></div><div>Yes. I think we&#39;re on the same page here. But ju=
st to be clear, I&#39;ll restate it again with my own words:</div><div><br>=
</div><div>Whatever the first parameter (the to-be-cloned object) of the cl=
one() function is called will be completely inaccessible as a property name=
.=C2=A0</div><div><br></div><div>clone($foo, __object: &quot;bar&quot;) wil=
l fail (Named parameter overwrites previous argument)</div><div>clone($foo,=
 ...[&quot;__object&quot; =3D&gt; &quot;bar&quot;]) will also fail.=C2=A0</=
div><div><br></div><div>While `clone(prop: &#39;new val&#39;, __object: $fo=
o)` just works.</div><div><br></div><div>For example, using the current imp=
lementation where the parameter is named `object`:</div><div>```</div><div>=
class Foo {<br>=C2=A0 =C2=A0 public int $bar;<br>}<br>$x =3D new Foo();<br>=
var_dump(clone(bar: 5, object: $x));</div></div><div><br></div><div>// obje=
ct(Foo)#2 (1) {<br>//=C2=A0 =C2=A0[&quot;bar&quot;]=3D&gt;<br>//=C2=A0 =C2=
=A0int(5)<br>// }</div><div>```</div><div><br></div><span class=3D"gmail_si=
gnature_prefix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature"><d=
iv dir=3D"ltr"><div style=3D"color:rgb(34,34,34);font-family:arial,sans-ser=
if;font-size:12.8px">Volker Dusch</div><div style=3D"color:rgb(34,34,34);fo=
nt-family:arial,sans-serif;font-size:12.8px">Head of Engineering</div><div =
style=3D"color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px"=
><div>Tideways GmbH</div><div>K=C3=B6nigswinterer Str. 116</div><div>53227 =
Bonn</div><div><a href=3D"https://tideways.io/imprint" style=3D"color:rgb(1=
7,85,204)" target=3D"_blank">https://tideways.io/imprint</a><br></div><div>=
<br></div><div>Sitz der Gesellschaft: Bonn</div><div>Gesch=C3=A4ftsf=C3=BCh=
rer: Benjamin Au=C3=9Fenhofer (geb. Eberlei)</div><div>Registergericht: Amt=
sgericht Bonn, HRB 22127</div></div></div></div></div>

--000000000000f4089d06352fb3dd--