Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127369
Message-ID: <F38892E6-4219-4B1A-A2C5-4F06AE70056F@koalephant.com>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_18462730-38B2-44C6-9471-6E711B7E85CB"
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\))
Subject: Re: [PHP-DEV] [RFC] Clone with v2
Date: Thu, 15 May 2025 13:22:45 +0700
In-Reply-To: <CAMzRQTfWj=CFsu=OyOiK_HiwCM5UkyPhfY3DiwSBF4N3FtzObA@mail.gmail.com>
Cc: Matthew Weier O'Phinney <mweierophinney@gmail.com>,
 php internals <internals@lists.php.net>,
 =?utf-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
To: Volker Dusch <volker@tideways-gmbh.com>
References: <CAMzRQTdePFXUMWO38g=gQA2vbqL5zp=o1cPt00ec41g95xys=g@mail.gmail.com>
 <CAJp_myXREmnyufwxj4tDCsopouUFEWenap5EJaH+sXKTyg4K1Q@mail.gmail.com>
 <CAMzRQTfWj=CFsu=OyOiK_HiwCM5UkyPhfY3DiwSBF4N3FtzObA@mail.gmail.com>
From: php-lists@koalephant.com (Stephen Reay)


--Apple-Mail=_18462730-38B2-44C6-9471-6E711B7E85CB
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8


> On 15 May 2025, at 06:26, Volker Dusch <volker@tideways-gmbh.com> =
wrote:
>=20
> On Wed, May 14, 2025 at 10:06=E2=80=AFPM Matthew Weier O'Phinney =
<mweierophinney@gmail.com <mailto:mweierophinney@gmail.com>> wrote:
>=20
> > The only question that arose for me is: what happens if a property =
name is provided to `clone()` that does not exist in the class =
definition; what will be the behavior at that time? Will an exception or =
error be thrown? If so, will it be a new one, or an existing one?=20
>=20
> Thank you for the question. I had that one myself looking at the =
initial implementation and forgot to write that down more explicitly.=20
>=20
> Tim already answered and linked the test, but I've also added an =
example to the RFC.
>=20
> --
> Volker Dusch
> Head of Engineering
> Tideways GmbH
> K=C3=B6nigswinterer Str. 116
> 53227 Bonn
> https://tideways.io/imprint
>=20
> Sitz der Gesellschaft: Bonn
> Gesch=C3=A4ftsf=C3=BChrer: Benjamin Au=C3=9Fenhofer (geb. Eberlei)
> Registergericht: Amtsgericht Bonn, HRB 22127

I may be missing something here..=20

So far the issues are "how do we deal with a parameter for the actual =
object, vs new properties to apply",  "should __clone be called before =
or after the changes" and "this won't allow regular readonly properties =
to be modified".

Isn't the previous suggestion of passing the new property arguments =
directly to the __clone method the obvious solution to all three =
problems?=20

There's no potential for a conflicting property name, the developer can =
use the new property values in the order they see fit relative to the =
logic in the __clone call, and it's inherently in scope to write to any =
(unlocked during __clone) readonly properties.



Cheers

Stephen=20




--Apple-Mail=_18462730-38B2-44C6-9471-6E711B7E85CB
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html;
	charset=utf-8

<html><head><meta http-equiv=3D"content-type" content=3D"text/html; =
charset=3Dutf-8"></head><body style=3D"overflow-wrap: break-word; =
-webkit-nbsp-mode: space; line-break: =
after-white-space;"><br><div><blockquote type=3D"cite"><div>On 15 May =
2025, at 06:26, Volker Dusch &lt;volker@tideways-gmbh.com&gt; =
wrote:</div><br class=3D"Apple-interchange-newline"><div><div =
dir=3D"ltr"><div dir=3D"ltr">On Wed, May 14, 2025 at 10:06=E2=80=AFPM =
Matthew Weier O'Phinney &lt;<a =
href=3D"mailto:mweierophinney@gmail.com">mweierophinney@gmail.com</a>&gt; =
wrote:</div><div dir=3D"ltr"><br></div><div dir=3D"ltr">&gt; The only =
question that arose for me is: what happens if a property name is =
provided to `clone()` that does not exist in the class definition; what =
will be the behavior at that time? Will an exception or error be thrown? =
If so, will it be a new one, or an existing one?&nbsp;</div><div =
dir=3D"ltr"><br></div><div>Thank you for the question. I had that one =
myself looking at the initial&nbsp;implementation and forgot to write =
that down more explicitly.&nbsp;</div><div><br></div><div>Tim already =
answered and linked the test, but I've also added an example to the =
RFC.</div><div><br></div><span class=3D"gmail_signature_prefix">-- =
</span><br><div dir=3D"ltr" class=3D"gmail_signature"><div =
dir=3D"ltr"><div =
style=3D"color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px=
">Volker Dusch</div><div =
style=3D"color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px=
">Head of Engineering</div><div =
style=3D"color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px=
"><div>Tideways GmbH</div><div>K=C3=B6nigswinterer Str. =
116</div><div>53227 Bonn</div><div><a href=3D"https://tideways.io/imprint"=
 style=3D"color:rgb(17,85,204)" =
target=3D"_blank">https://tideways.io/imprint</a><br></div><div><br></div>=
<div>Sitz der Gesellschaft: Bonn</div><div>Gesch=C3=A4ftsf=C3=BChrer: =
Benjamin Au=C3=9Fenhofer (geb. Eberlei)</div><div>Registergericht: =
Amtsgericht Bonn, HRB 22127</div></div></div></div></div>
</div></blockquote></div><br><div>I may be missing something =
here..&nbsp;</div><div><br></div><div>So far the issues are "how do we =
deal with a parameter for the actual object, vs new properties to =
apply", &nbsp;"should __clone be called before or after the changes" and =
"this won't allow regular readonly properties to be =
modified".</div><div><br></div><div>Isn't the previous suggestion of =
passing the new property arguments directly to the __clone method the =
obvious solution to all three =
problems?&nbsp;</div><div><br></div><div>There's no potential for a =
conflicting property name, the developer can use the new property values =
in the order they see fit relative to the logic in the __clone call, and =
it's inherently in scope to write to any (unlocked during __clone) =
readonly =
properties.</div><div><br></div><div><br></div><div><br></div><div>Cheers<=
/div><div><br></div><div>Stephen&nbsp;</div><div><br></div><div><br></div>=
<div><br></div></body></html>=

--Apple-Mail=_18462730-38B2-44C6-9471-6E711B7E85CB--